test: add smoke test for user role for userdata crud api by shwstppr · Pull Request #7332 · apache/cloudstack

shwstppr · 2023-03-13T09:05:34Z

Description

Adds smoke test for CRUD operations as a normal user

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2023-03-13T09:08:31Z

@blueorangutan package

blueorangutan · 2023-03-13T09:09:04Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

harikrishna-patnala · 2023-03-13T09:24:49Z

code looks good to me, I'll wait for the smoke test results.

blueorangutan · 2023-03-13T10:23:32Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5712

shwstppr · 2023-03-13T10:26:42Z

@blueorangutan test

blueorangutan · 2023-03-13T10:29:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2023-03-13T11:42:01Z

+            self.userapiclient,
+            id=self.userdata.userdata.id
+        )
+        self.cleanup.pop()


:D I would have

Suggested change

self.cleanup.pop()

self.cleanup.remove(self.userdata)

but this should work as well 👍

codecov · 2023-03-13T12:15:19Z

Codecov Report

Merging #7332 (9d8be8b) into main (f64f7b9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #7332   +/-   ##
=========================================
  Coverage     12.68%   12.68%           
  Complexity     8654     8654           
=========================================
  Files          2716     2716           
  Lines        256117   256117           
  Branches      39928    39928           
=========================================
  Hits          32499    32499           
  Misses       219485   219485           
  Partials       4133     4133

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

blueorangutan · 2023-03-13T21:58:46Z

Trillian test result (tid-6278)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39946 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7332-t6278-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

harikrishna-patnala

Verified the test results.
Test following operations as a normal user: ... === TestName: test_user_userdata_crud | Status : SUCCESS ===

LGTM

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2023-03-14T07:09:53Z

@blueorangutan package

blueorangutan · 2023-03-14T07:11:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2023-03-14T08:11:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

blueorangutan · 2023-03-14T08:12:04Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5719

yadvr

Thanks @shwstppr

shwstppr · 2023-03-15T06:17:03Z

@blueorangutan test

blueorangutan · 2023-03-15T06:18:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-03-15T17:18:42Z

Trillian test result (tid-6282)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38261 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7332-t6282-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

shwstppr · 2023-03-31T06:55:29Z

@blueorangutan package

blueorangutan · 2023-03-31T06:56:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-03-31T07:49:02Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5821

yadvr · 2023-03-31T09:46:48Z

Merging this for 4.18, main was previously 4.18 when the smoketests had passed.

* test: add smoke test for user role for userdata crud api Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> * address review comment Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com> --------- Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

test: add smoke test for user role for userdata crud api

c01edd9

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Mar 13, 2023

shwstppr requested a review from harikrishna-patnala March 13, 2023 09:05

DaanHoogland reviewed Mar 13, 2023

View reviewed changes

harikrishna-patnala approved these changes Mar 14, 2023

View reviewed changes

address review comment

9d8be8b

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr approved these changes Mar 14, 2023

View reviewed changes

yadvr added this to the 4.18.1.0 milestone Mar 14, 2023

DaanHoogland approved these changes Mar 15, 2023

View reviewed changes

yadvr changed the base branch from main to 4.18 March 16, 2023 10:25

yadvr merged commit 330a330 into apache:4.18 Mar 31, 2023

yadvr deleted the test-user-userdataapi-crud branch March 31, 2023 09:46

Conversation

shwstppr commented Mar 13, 2023

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

shwstppr commented Mar 13, 2023

Uh oh!

blueorangutan commented Mar 13, 2023

Uh oh!

harikrishna-patnala commented Mar 13, 2023

Uh oh!

blueorangutan commented Mar 13, 2023

Uh oh!

shwstppr commented Mar 13, 2023

Uh oh!

blueorangutan commented Mar 13, 2023

Uh oh!

DaanHoogland Mar 13, 2023

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Mar 13, 2023

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Mar 14, 2023

Uh oh!

blueorangutan commented Mar 14, 2023

Uh oh!

sonarqubecloud Bot commented Mar 14, 2023

Uh oh!

blueorangutan commented Mar 14, 2023

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Mar 15, 2023

Uh oh!

blueorangutan commented Mar 15, 2023

Uh oh!

blueorangutan commented Mar 15, 2023

Uh oh!

shwstppr commented Mar 31, 2023

Uh oh!

blueorangutan commented Mar 31, 2023

Uh oh!

blueorangutan commented Mar 31, 2023

Uh oh!

yadvr commented Mar 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Mar 13, 2023 •

edited

Loading