remove powermock from engine#7975
Merged
DaanHoogland merged 3 commits intoapache:mainfrom Sep 20, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7975 +/- ##
============================================
+ Coverage 29.16% 29.19% +0.03%
- Complexity 30383 30427 +44
============================================
Files 5100 5100
Lines 358291 358320 +29
Branches 52305 52308 +3
============================================
+ Hits 104510 104626 +116
+ Misses 239410 239322 -88
- Partials 14371 14372 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 44 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
@blueorangutan package |
|
@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7062 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes powermock from tests in engine/ directory.
Didn't remove powermock from
ConfigDriveBuilderTest.javabecause powermock is being used to mock File class which is not possible with Mockito as of now. Ref: mockito/mockito#1833Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?