Skip to content

Migrate to a newer JDK#8411

Closed
vishesh92 wants to merge 2 commits intoapache:mainfrom
shapeblue:migrate-jdk-17
Closed

Migrate to a newer JDK#8411
vishesh92 wants to merge 2 commits intoapache:mainfrom
shapeblue:migrate-jdk-17

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Dec 28, 2023

Description

This PR migrates jdk version from 11 to 21 🤞🏽 .

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d4f071) 30.80% compared to head (a865652) 4.39%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #8411       +/-   ##
============================================
- Coverage     30.80%   4.39%   -26.42%     
============================================
  Files          5341     361     -4980     
  Lines        374864   28622   -346242     
  Branches      54518    4992    -49526     
============================================
- Hits         115485    1258   -114227     
+ Misses       244114   27225   -216889     
+ Partials      15265     139    -15126     
Flag Coverage Δ
simulator-marvin-tests ?
uitests 4.39% <ø> (ø)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start let's see this through (cc @JoaoJandre )

Comment thread engine/schema/pom.xml
<version>1.5</version>
<groupId>org.codehaus.gmavenplus</groupId>
<artifactId>gmavenplus-plugin</artifactId>
<version>3.0.2</version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this come from the parent pom?

Comment thread pom.xml Outdated

<!-- Build properties -->
<cs.jdk.version>11</cs.jdk.version>
<cs.jdk.version>17</cs.jdk.version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do 21 we have more time to think of our sins.

Suggested change
<cs.jdk.version>17</cs.jdk.version>
<cs.jdk.version>21</cs.jdk.version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this remains to be seen. depending on availabilities of libraries

@vishesh92 vishesh92 changed the title Migrate to JDK 17 Migrate to OpenJDK 21 Dec 28, 2023
@DaanHoogland DaanHoogland changed the title Migrate to OpenJDK 21 Migrate to a newer JDK Dec 29, 2023
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 5, 2024

@vishesh92 @weizhouapache can this be closed if #8411 is melded with #8497 ?

@vishesh92
Copy link
Copy Markdown
Member Author

@vishesh92 @weizhouapache can this be closed if #8411 is melded with #8497 ?

This PR was for migrating the JDK and upgrade the packages required for that as well. This will require a lot of work.

I am closing this PR for now. I will try to do this later in a way which includes small changes instead of a big PR. Most likely for 4.21.

@vishesh92 vishesh92 closed this Feb 5, 2024
@DaanHoogland DaanHoogland added this to the unplanned milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants