Skip to content

Fix ssl check in object store browser#8430

Merged
shwstppr merged 1 commit intoapache:mainfrom
shapeblue:fix-ssl-storage-browser
Jan 4, 2024
Merged

Fix ssl check in object store browser#8430
shwstppr merged 1 commit intoapache:mainfrom
shapeblue:fix-ssl-storage-browser

Conversation

@vishesh92
Copy link
Copy Markdown
Member

Description

This PR fixes the ssl in image store browser.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9d4f071) 30.80% compared to head (34a4cd2) 30.75%.

Files Patch % Lines
ui/src/components/view/ObjectStoreBrowser.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8430      +/-   ##
============================================
- Coverage     30.80%   30.75%   -0.06%     
+ Complexity    33981    33933      -48     
============================================
  Files          5341     5341              
  Lines        374864   374864              
  Branches      54518    54518              
============================================
- Hits         115485   115291     -194     
- Misses       244114   244332     +218     
+ Partials      15265    15241      -24     
Flag Coverage Δ
simulator-marvin-tests 24.63% <ø> (-0.09%) ⬇️
uitests 4.39% <0.00%> (ø)
unit-tests 16.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Jan 3, 2024

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8430 (QA-JID-250)

@vishesh92 vishesh92 changed the title Fix ssl check in image store browser Fix ssl check in object store browser Jan 3, 2024
@DaanHoogland DaanHoogland added this to the 4.19.0.0 milestone Jan 3, 2024
@DaanHoogland
Copy link
Copy Markdown
Contributor

@wido , can you test this?

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@wido
Copy link
Copy Markdown
Contributor

wido commented Jan 3, 2024

@wido , can you test this?

Yes. Will do so tomorrow (04-04-2024)

@wido wido self-requested a review January 4, 2024 10:04
Copy link
Copy Markdown
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my test environment and works as expected.

CORS gave me some troubles, but that is not related to this issue, local config problems.

LGTM

@shwstppr shwstppr merged commit 2eaed80 into apache:main Jan 4, 2024
@shwstppr shwstppr deleted the fix-ssl-storage-browser branch January 4, 2024 11:56
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 9, 2024
This PR fixes the ssl in image store browser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants