ui: fix layout for action button for template form#8434
Merged
shwstppr merged 1 commit intoapache:mainfrom Jan 4, 2024
Merged
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8434 +/- ##
=========================================
Coverage 30.80% 30.80%
- Complexity 33981 33987 +6
=========================================
Files 5341 5341
Lines 374864 374864
Branches 54518 54518
=========================================
+ Hits 115485 115491 +6
Misses 244114 244114
+ Partials 15265 15259 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
yadvr
approved these changes
Jan 4, 2024
harikrishna-patnala
approved these changes
Jan 4, 2024
Member
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
There was a problem hiding this comment.
LGTM.
tested with https://qa.cloudstack.cloud/simulator/pr/8434
Also reproduced the issue with old qa servers.
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Jan 9, 2024
Fixes layout for the action buttons on register template form Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes layout for the action buttons on register template form
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
How did you try to break this feature and the system with this change?