ui: fix default domainid for add account#8435
Conversation
Fixes setting domainid param default value which was being set to 0. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8435 +/- ##
============================================
- Coverage 30.80% 30.80% -0.01%
+ Complexity 33981 33977 -4
============================================
Files 5341 5341
Lines 374864 374863 -1
Branches 54518 54518
============================================
- Hits 115485 115462 -23
- Misses 244114 244148 +34
+ Partials 15265 15253 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, the qa link doesn't work for me, any idea on that @shwstppr ?
|
@DaanHoogland it is working for me. For you is the page to opening or login not working or the fix not working? Incognito window may help |
| } else { | ||
| this.loadMore(apiToCall, page + 1, sema) | ||
| } | ||
| this.form.domainid = 0 |
There was a problem hiding this comment.
not sure if it's applicable here - there's also a way to delete this.form.domainid if the key/value need to be removed from the object.
There was a problem hiding this comment.
@rohityadavcloud don't think we need to remove domainid from the object as API call will be just adding to the existing list so previous selection will still be there
harikrishna-patnala
left a comment
harikrishna-patnala
left a comment
There was a problem hiding this comment.
LGTM
verified with https://qa.cloudstack.cloud/simulator/pr/8435
Fixes setting domainid param default value which was being set to 0. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
5 participants
Description
Fixes setting domainid param default value which was being set to 0.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
How did you try to break this feature and the system with this change?