ui: prevent scheduling readyforshutdown job when api inaccessible#8448
Conversation
Non-admin account may not have access to the readyForShutdown API therefore UI should not schedule the job. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8448 +/- ##
============================================
- Coverage 30.80% 30.80% -0.01%
+ Complexity 33981 33976 -5
============================================
Files 5341 5341
Lines 374864 374870 +6
Branches 54518 54521 +3
============================================
- Hits 115485 115475 -10
- Misses 244114 244132 +18
+ Partials 15265 15263 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm (good cleanup!)
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
There was a problem hiding this comment.
@shwstppr agree for the issue and fix but I don't see this getting called for admin account also, anything we are missing here ?
I've verified on other server and there I can see that at regular intervals but not in above case
|
@harikrishna-patnala did you try on qa server? |
I've tried on the env built on top this PR @shwstppr https://qa.cloudstack.cloud/simulator/pr/8448 |
|
@harikrishna-patnala let me build an env @blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8227 |
…ache#8448) Non-admin account may not have access to the readyForShutdown API therefore UI should not schedule the job. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Description
Non-admin accounts may not have access to the readyForShutdown API therefore UI should not schedule the job.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Without fix errors can be seen for the readyForShutdown API call when logged in as normal account,

How Has This Been Tested?
How did you try to break this feature and the system with this change?