Skip to content

UI: Add reconnect button to hosts on alert#8468

Merged
shwstppr merged 1 commit intoapache:4.18from
scclouds:reconnect-alert-host-ui
Jan 10, 2024
Merged

UI: Add reconnect button to hosts on alert#8468
shwstppr merged 1 commit intoapache:4.18from
scclouds:reconnect-alert-host-ui

Conversation

@hsato03
Copy link
Copy Markdown
Member

@hsato03 hsato03 commented Jan 8, 2024

Description

Currently, if a host is on alert, the option to reconnect it is not presented in the UI.

This PR addresses this issue by adding a reconnect button to the host if it is in an alert state.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2024-01-08 15-36-50

How Has This Been Tested?

With a host on alert, I verified that the option to reconnect was present and, upon using it, I observed that the host reconnected as expected.

@hsato03 hsato03 changed the title Add reconnect button to hosts on alert UI: Add reconnect button to hosts on alert Jan 8, 2024
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f023fc5) 13.12% compared to head (3a10d73) 29.54%.

Additional details and impacted files
@@              Coverage Diff              @@
##               4.18    #8468       +/-   ##
=============================================
+ Coverage     13.12%   29.54%   +16.41%     
- Complexity     9142    32266    +23124     
=============================================
  Files          2720     5341     +2621     
  Lines        257744   374918   +117174     
  Branches      40182    54534    +14352     
=============================================
+ Hits          33839   110752    +76913     
- Misses       219615   249487    +29872     
- Partials       4290    14679    +10389     
Flag Coverage Δ
simulator-marvin-tests 22.97% <ø> (?)
uitests 4.39% <ø> (?)
unit-tests 16.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiranchavala
Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8468 (QA-JID-255)

@kiranchavala
Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8242

Copy link
Copy Markdown
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested manually

Before fix
Reconnect

After fix

Reconnect2

@weizhouapache
Copy link
Copy Markdown
Member

@hsato03
Can you re-target to 4.18?

@hsato03 hsato03 force-pushed the reconnect-alert-host-ui branch from 02de6f8 to 3a10d73 Compare January 9, 2024 17:05
@hsato03 hsato03 changed the base branch from main to 4.18 January 9, 2024 17:05
@hsato03
Copy link
Copy Markdown
Member Author

hsato03 commented Jan 9, 2024

@hsato03 Can you re-target to 4.18?

Sure, I changed the target branch.

@weizhouapache
Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8468 (QA-JID-257)

@shwstppr shwstppr added this to the 4.18.2.0 milestone Jan 10, 2024
@shwstppr shwstppr merged commit 76aff0f into apache:4.18 Jan 10, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 12, 2024
Currently, if a host is on alert, the option to reconnect it is not presented in the UI.

This PR addresses this issue by adding a reconnect button to the host if it is in an alert state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants