Skip to content

Register managed user data using POST call from UI (to support user data content > 4096 bytes)#8487

Merged
shwstppr merged 1 commit intoapache:mainfrom
shapeblue:ui-managed-user-data-using-post-call
Jan 10, 2024
Merged

Register managed user data using POST call from UI (to support user data content > 4096 bytes)#8487
shwstppr merged 1 commit intoapache:mainfrom
shapeblue:ui-managed-user-data-using-post-call

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

Description

This PR allows to register managed user data using POST call from UI (to support user data content > 4096 bytes).

Partially fixes #8415

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Manually tested managed user data (content > 4096 bytes) registration from UI.

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

sureshanaparti added a commit to shapeblue/cloudstack that referenced this pull request Jan 10, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6d916ca) 30.85% compared to head (2767862) 26.73%.
Report is 19 commits behind head on main.

Files Patch % Lines
ui/src/views/compute/RegisterUserData.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8487      +/-   ##
============================================
- Coverage     30.85%   26.73%   -4.12%     
+ Complexity    34048    28919    -5129     
============================================
  Files          5341     5341              
  Lines        374861   374918      +57     
  Branches      54518    54534      +16     
============================================
- Hits         115659   100239   -15420     
- Misses       243973   261375   +17402     
+ Partials      15229    13304    -1925     
Flag Coverage Δ
simulator-marvin-tests 19.10% <ø> (-5.65%) ⬇️
uitests 4.39% <0.00%> (ø)
unit-tests 16.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8487 (QA-JID-258)

Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified the POST API call

@shwstppr shwstppr added this to the 4.19.0.0 milestone Jan 10, 2024
@shwstppr shwstppr merged commit 32f3792 into apache:main Jan 10, 2024
@DaanHoogland DaanHoogland deleted the ui-managed-user-data-using-post-call branch January 10, 2024 06:37
Copy link
Copy Markdown
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested manually

Compute> Userdata

Before fix, the call was a GET Call

Screenshot 2024-01-10 at 12 02 55 PM

After fix, the call is a post call

Screenshot 2024-01-10 at 12 04 36 PM

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 12, 2024
…ata content > 4096 bytes) (apache#8487)

This PR allows to register managed user data using POST call from UI (to support user data content > 4096 bytes).

Partially fixes apache#8415
sureshanaparti added a commit to shapeblue/cloudstack that referenced this pull request Jun 7, 2024
sureshanaparti added a commit to shapeblue/cloudstack that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to create managed user data, with content > (around)3100 bytes

5 participants