Skip to content

Rename "Import QCOW...." to "Import QCOW2....."#8519

Merged
shwstppr merged 5 commits intomainfrom
import-qcow-rename
Jan 18, 2024
Merged

Rename "Import QCOW...." to "Import QCOW2....."#8519
shwstppr merged 5 commits intomainfrom
import-qcow-rename

Conversation

@andrijapanicsb
Copy link
Copy Markdown
Contributor

@andrijapanicsb andrijapanicsb commented Jan 16, 2024

Minor UI updates, renaming "Import QCOW...." to "Import QCOW2....."

@andrijapanicsb andrijapanicsb changed the title Update ManageInstances.vue Rename "Import QCOW...." to "Import QCOW2....." Jan 16, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3b77cb) 18.28% compared to head (1b83ce3) 21.93%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8519      +/-   ##
============================================
+ Coverage     18.28%   21.93%   +3.65%     
- Complexity    16826    22316    +5490     
============================================
  Files          4848     5209     +361     
  Lines        324301   352925   +28624     
  Branches      45561    50554    +4993     
============================================
+ Hits          59290    77417   +18127     
- Misses       256437   264375    +7938     
- Partials       8574    11133    +2559     
Flag Coverage Δ
simulator-marvin-tests 23.48% <ø> (+5.20%) ⬆️
uitests 4.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@shwstppr
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8519 (QA-JID-264)

Comment thread ui/public/locales/en.json
"label.desc.import.ext.kvm.wizard": "Import libvirt domain from KVM Host",
"label.desc.import.local.kvm.wizard": "Import QCOW image from Local Storage",
"label.desc.import.shared.kvm.wizard": "Import QCOW image from Shared Storage",
"label.desc.import.ext.kvm.wizard": "Import Instance from remote KVM host",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really "remote"? this is a configured host in cloudstack is it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's an external host (not part ACS, needs to run libvirt i.e. also NOT proxmox host) - so... hm it can be either "remote" or "external" KVM host - opinions?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, no is good never mind

@nvazquez nvazquez marked this pull request as draft January 17, 2024 12:42
@andrijapanicsb
Copy link
Copy Markdown
Contributor Author

@shwstppr @DaanHoogland - can we please include this one in the 4.19 RC3 (since we are crafting it as it seems) - this is a simple UI fixed, not code.

@andrijapanicsb andrijapanicsb added this to the 4.19.0.0 milestone Jan 18, 2024
@andrijapanicsb andrijapanicsb marked this pull request as ready for review January 18, 2024 12:30
@shwstppr shwstppr merged commit 3bcf6f0 into main Jan 18, 2024
@shwstppr shwstppr deleted the import-qcow-rename branch January 18, 2024 12:37
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 26, 2024
Minor UI updates, renaming "Import QCOW...." to "Import QCOW2....."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants