Skip to content

NSX: Support internal LB service in NSX#8559

Closed
Pearl1594 wants to merge 2 commits intonsx-integrationfrom
nsx-support-ilb
Closed

NSX: Support internal LB service in NSX#8559
Pearl1594 wants to merge 2 commits intonsx-integrationfrom
nsx-support-ilb

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2024

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (5a4f38c) 29.24% compared to head (fca1df4) 15.80%.
Report is 10 commits behind head on nsx-integration.

Files Patch % Lines
...java/org/apache/cloudstack/service/NsxElement.java 18.18% 35 Missing and 1 partial ⚠️
...va/org/apache/cloudstack/service/NsxApiClient.java 0.00% 4 Missing ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java 20.00% 3 Missing and 1 partial ⚠️
...java/com/cloud/server/ConfigurationServerImpl.java 0.00% 4 Missing ⚠️
ui/src/views/network/VpcTiersTab.vue 0.00% 3 Missing ⚠️
...oudstack/api/response/NetworkOfferingResponse.java 0.00% 2 Missing ⚠️
...ommand/admin/network/CreateNetworkOfferingCmd.java 0.00% 1 Missing ⚠️
...loud/api/query/dao/NetworkOfferingJoinDaoImpl.java 0.00% 1 Missing ⚠️
ui/src/views/offering/AddNetworkOffering.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             nsx-integration    #8559       +/-   ##
======================================================
- Coverage              29.24%   15.80%   -13.44%     
+ Complexity             32174    15975    -16199     
======================================================
  Files                   5377     5152      -225     
  Lines                 377973   363048    -14925     
  Branches               54940    53161     -1779     
======================================================
- Hits                  110550    57396    -53154     
- Misses                252658   298854    +46196     
+ Partials               14765     6798     -7967     
Flag Coverage Δ
simulator-marvin-tests ?
uitests 4.37% <0.00%> (-0.01%) ⬇️
unit-tests 16.79% <18.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pearl1594
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8436

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@nvazquez nvazquez closed this Feb 10, 2024
@DaanHoogland DaanHoogland added this to the unplanned milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants