Added missing metrics English locale strings by kohrar · Pull Request #8560 · apache/cloudstack

kohrar · 2024-01-23T22:06:00Z

Description

This PR fixes two missing English locale strings that are missing in the metrics page in 4.18.1.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Rebuilt UI

How did you try to break this feature and the system with this change?

Trivial change and should not have any other side effects.

codecov · 2024-01-24T06:15:23Z

Codecov Report

Attention: 844 lines in your changes are missing coverage. Please review.

Comparison is base (33bb92a) 13.16% compared to head (7eca5b1) 30.77%.

❗ Current head 7eca5b1 differs from pull request most recent head 874daba. Consider uploading reports for the commit 874daba to get more accurate results

Files	Patch %	Lines
api/src/main/java/com/cloud/gpu/GPU.java	0.00%	98 Missing ⚠️
...apache/cloudstack/api/response/BucketResponse.java	0.00%	69 Missing ⚠️
...stack/api/command/user/bucket/CreateBucketCmd.java	2.56%	38 Missing ⚠️
...i/response/SecondaryStorageHeuristicsResponse.java	0.00%	34 Missing ⚠️
...nt/resource/consoleproxy/ConsoleProxyResource.java	0.00%	33 Missing ⚠️
...e/cloudstack/api/command/admin/vm/ImportVmCmd.java	3.12%	31 Missing ⚠️
...stack/api/command/user/bucket/UpdateBucketCmd.java	3.84%	25 Missing ⚠️
...ack/api/command/user/snapshot/CopySnapshotCmd.java	51.06%	15 Missing and 8 partials ⚠️
...command/admin/storage/AddObjectStoragePoolCmd.java	40.54%	20 Missing and 2 partials ⚠️
...e/cloudstack/api/response/ObjectStoreResponse.java	9.52%	19 Missing ⚠️
... and 92 more

Additional details and impacted files

@@              Coverage Diff              @@
##               4.18    #8560       +/-   ##
=============================================
+ Coverage     13.16%   30.77%   +17.60%     
- Complexity     9201    33968    +24767     
=============================================
  Files          2724     5341     +2617     
  Lines        258077   375027   +116950     
  Branches      40224    54554    +14330     
=============================================
+ Hits          33981   115415    +81434     
- Misses       219790   244350    +24560     
- Partials       4306    15262    +10956

Flag	Coverage Δ
simulator-marvin-tests	`24.62% <28.87%> (?)`
uitests	`4.39% <ø> (?)`
unit-tests	`16.49% <35.41%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shwstppr · 2024-01-24T08:26:51Z

@kohrar this needs to be targetted to 4.18 branch if you would want it to go in 4.18.2 cc @JoaoJandre

sureshanaparti

changes lgtm

JoaoJandre

LGTM

DaanHoogland · 2024-01-24T14:40:17Z

@blueorangutan ui

blueorangutan · 2024-01-24T14:41:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-01-24T14:56:29Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8560 (QA-JID-268)

DaanHoogland

lgtm, tested in qa

DaanHoogland · 2024-01-24T15:17:45Z

@sureshanaparti this is based on main so I changed the milestone to 4.20.
@kohrar if you wnat this in 4.18.2 please git rebase --onto 4.18 <current base> <head>
cc @JoaoJandre

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

kohrar · 2024-01-24T18:40:11Z

@sureshanaparti this is based on main so I changed the milestone to 4.20. @kohrar if you wnat this in 4.18.2 please git rebase --onto 4.18 <current base> <head> cc @JoaoJandre

@DaanHoogland Thanks. I didn't realize I targetted main. I'll keep that in mind in the future. I've created a new PR (#8564) that targets 4.18. Is this the correct approach?

harikrishna-patnala · 2024-01-25T06:18:25Z

@sureshanaparti this is based on main so I changed the milestone to 4.20. @kohrar if you wnat this in 4.18.2 please git rebase --onto 4.18 <current base> <head> cc @JoaoJandre

@DaanHoogland Thanks. I didn't realize I targetted main. I'll keep that in mind in the future. I've created a new PR (#8564) that targets 4.18. Is this the correct approach?

We don't have to create two PRs for two branches @kohrar. You can simply rebase this current branch with 4.18 (or force push to add_missing_en_locale) and change the apache:main to apache:4.18 in this PR itself.

github-actions · 2024-01-25T08:22:58Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

kohrar · 2024-01-25T08:32:32Z

@sureshanaparti this is based on main so I changed the milestone to 4.20. @kohrar if you wnat this in 4.18.2 please git rebase --onto 4.18 <current base> <head> cc @JoaoJandre

@DaanHoogland Thanks. I didn't realize I targetted main. I'll keep that in mind in the future. I've created a new PR (#8564) that targets 4.18. Is this the correct approach?

We don't have to create two PRs for two branches @kohrar. You can simply rebase this current branch with 4.18 (or force push to add_missing_en_locale) and change the apache:main to apache:4.18 in this PR itself.

😅 Thanks for the pointer. It took me a little too long to figure out how to change the PR to target 4.18 on GitHub. I hope that I got it right now!

DaanHoogland · 2024-01-25T09:46:25Z

retesting;
@blueorangutan ui

blueorangutan · 2024-01-25T09:49:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2024-01-25T10:01:16Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8560 (QA-JID-270)

* Update ui/public/locales/en.json Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> * Update ui/public/locales/en.json Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com> --------- Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

boring-cyborg Bot added the component:UI label Jan 23, 2024

sureshanaparti reviewed Jan 24, 2024

View reviewed changes

Comment thread ui/public/locales/en.json Outdated

sureshanaparti added this to the 4.18.2.0 milestone Jan 24, 2024

sureshanaparti reviewed Jan 24, 2024

View reviewed changes

Comment thread ui/public/locales/en.json Outdated

sureshanaparti approved these changes Jan 24, 2024

View reviewed changes

JoaoJandre approved these changes Jan 24, 2024

View reviewed changes

DaanHoogland approved these changes Jan 24, 2024

View reviewed changes

DaanHoogland modified the milestones: 4.18.2.0, 4.20.0.0 Jan 24, 2024

kohrar and others added 2 commits January 24, 2024 11:29

Update ui/public/locales/en.json

0711b26

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

Update ui/public/locales/en.json

874daba

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

kohrar mentioned this pull request Jan 24, 2024

UI: Added missing metrics English locale strings (for 4.18) #8564

Closed

13 tasks

kohrar force-pushed the add_missing_en_locale branch from 7eca5b1 to 874daba Compare January 25, 2024 08:22

boring-cyborg Bot added component:api component:backup component:build component:integration-test component:marvin component:vmware Python Warning... Python code Ahead! labels Jan 25, 2024

github-actions Bot added the status:has-conflicts label Jan 25, 2024

kohrar changed the base branch from main to 4.18 January 25, 2024 08:30

github-actions Bot removed the status:has-conflicts label Jan 25, 2024

DaanHoogland added the status:ready-for-merge label Jan 25, 2024

yadvr approved these changes Jan 29, 2024

View reviewed changes

yadvr modified the milestones: 4.20.0.0, 4.18.2.0 Jan 29, 2024

yadvr merged commit ca55fc0 into apache:4.18 Feb 5, 2024

DaanHoogland removed the status:ready-for-merge label Dec 4, 2024

Conversation

kohrar commented Jan 23, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Uh oh!

codecov Bot commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

shwstppr commented Jan 24, 2024

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

JoaoJandre left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jan 24, 2024

Uh oh!

blueorangutan commented Jan 24, 2024

Uh oh!

blueorangutan commented Jan 24, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jan 24, 2024

Uh oh!

kohrar commented Jan 24, 2024

Uh oh!

harikrishna-patnala commented Jan 25, 2024

Uh oh!

github-actions Bot commented Jan 25, 2024

Uh oh!

kohrar commented Jan 25, 2024

Uh oh!

DaanHoogland commented Jan 25, 2024

Uh oh!

blueorangutan commented Jan 25, 2024

Uh oh!

blueorangutan commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov Bot commented Jan 24, 2024 •

edited

Loading