UI: fix icmp code/type of ACL rule are not display if the value is -1

[weizhouapache]

Description

This PR fixes #8583

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan ui

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8589 (QA-JID-272)

[weizhouapache]

@NuxRo @rajujith
tested on QA server
https://qa.cloudstack.cloud/client/pr/8589/#/acllist/5c1191c2-72e4-4855-89b3-f1305908a926?tab=acl.list.rules

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c98b5a) 13.16% compared to head (c7aaedf) 13.16%.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.18    #8589   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
  Complexity     9201     9201           
=========================================
  Files          2724     2724           
  Lines        258087   258087           
  Branches      40223    40223           
=========================================
  Hits          33984    33984           
  Misses       219797   219797           
  Partials       4306     4306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NuxRo]

LGTM