Linstor fix migration while node offline#8610
Merged
yadvr merged 3 commits intoapache:4.18from Feb 8, 2024
Merged
Conversation
If a Linstor node is down while migrating resource, allow-two-primaries setting will fail because we can't reach the downed node. But it will still set the property on the other nodes and migration should work. We now just report an error instead of completely failing.
rp-
force-pushed
the
linstor-fix-migration-while-node-offline
branch
from
83730d2 to
1f6954c
Compare
Contributor
Author
|
Commit: 1f6954c should also be applied to 4.19 and main |
| // do not fail here as removing allow-two-primaries property isn't fatal | ||
| } | ||
| } | ||
| return false; |
Contributor
There was a problem hiding this comment.
@rp- any case returns false (on error / exception above ?)
Contributor
Author
There was a problem hiding this comment.
AFAIS every upper caller is ignoring the return value anyway
But we don't need to do any disconnect, it is just a bit of a tidy up to remove the property and nothing fatal if it fails.
Contributor
Entire PR changes can be forward merged to 4.19 / main. I think, merge excludes other changes if there are already in. |
Contributor
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Member
|
Merged based on smoketests. All changes in Linstor plugin. |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Feb 20, 2024
* linstor: Add util method getBestErrorMessage from main * linstor: failed remove of allow-two-primaries is no fatal error * linstor: Fix failure if a Linstor node is down while migrating If a Linstor node is down while migrating resource, allow-two-primaries setting will fail because we can't reach the downed node. But it will still set the property on the other nodes and migration should work. We now just report an error instead of completely failing.
rp-
added a commit
to LINBIT/cloudstack
that referenced
this pull request
May 16, 2024
* linstor: Add util method getBestErrorMessage from main * linstor: failed remove of allow-two-primaries is no fatal error * linstor: Fix failure if a Linstor node is down while migrating If a Linstor node is down while migrating resource, allow-two-primaries setting will fail because we can't reach the downed node. But it will still set the property on the other nodes and migration should work. We now just report an error instead of completely failing.
rp-
added a commit
to LINBIT/cloudstack
that referenced
this pull request
Feb 24, 2026
* linstor: Add util method getBestErrorMessage from main * linstor: failed remove of allow-two-primaries is no fatal error * linstor: Fix failure if a Linstor node is down while migrating If a Linstor node is down while migrating resource, allow-two-primaries setting will fail because we can't reach the downed node. But it will still set the property on the other nodes and migration should work. We now just report an error instead of completely failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a Linstor node is down while migrating resource, allow-two-primaries
setting will fail because we can't reach the downed node. But it will
still set the property on the other nodes and migration should work.
We now just report an error instead of completely failing.
This PR also containes a cherry-picked commit from the main branch f176e7d
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Nested Linstor cluster with a non hyperconverged setup and a node evicted.
How did you try to break this feature and the system with this change?