Skip to content

kvm: support Rocky/RHEL/OL/Alma in the same cluster#8641

Merged
yadvr merged 2 commits intoapache:4.18from
weizhouapache:4.18-kvm-compatible-oses
Jun 24, 2024
Merged

kvm: support Rocky/RHEL/OL/Alma in the same cluster#8641
yadvr merged 2 commits intoapache:4.18from
weizhouapache:4.18-kvm-compatible-oses

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Feb 12, 2024

Description

This PR fixes #8604

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Copy Markdown
Member Author

@DaanHoogland @rohityadavcloud
how about this ?

@weizhouapache weizhouapache added this to the 4.18.2.0 milestone Feb 12, 2024
@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 13.16%. Comparing base (672206c) to head (865c356).
Report is 11 commits behind head on 4.18.

Files Patch % Lines
...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.18    #8641   +/-   ##
=========================================
  Coverage     13.16%   13.16%           
- Complexity     9200     9205    +5     
=========================================
  Files          2724     2724           
  Lines        258109   258116    +7     
  Branches      40228    40229    +1     
=========================================
+ Hits          33971    33986   +15     
+ Misses       219835   219823   -12     
- Partials       4303     4307    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8630

@weizhouapache weizhouapache force-pushed the 4.18-kvm-compatible-oses branch from 9620fc4 to 865c356 Compare February 12, 2024 16:16
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 13, 2024

One remark - we shouldn't allow mixing different major versions of any of these EL distros though. (so OL8 with Alma8 is okay, but not OL7 with Alma8)

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks good to me @weizhouapache . I've been looking to see if we can guarantee what @rohityadavcloud states, as it makes sense. However, whether or not, that part of the logic doesn't change here, CLGTM. (and unit tests added!)

@weizhouapache
Copy link
Copy Markdown
Member Author

This code looks good to me @weizhouapache . I've been looking to see if we can guarantee what @rohityadavcloud states, as it makes sense. However, whether or not, that part of the logic doesn't change here, CLGTM. (and unit tests added!)

agree @rohityadavcloud @DaanHoogland

Currently it is supported to put different version of same OS distribution in the same cluster, for example ol8 and ol9, rocky8 and rocky9. It might be useful for users to upgrade the OSes.
Normally the vm migration from older QEMU (e.g in rocky8) to newer QEMU (e.g. in rocky9) should work.

@weizhouapache weizhouapache marked this pull request as ready for review February 13, 2024 09:02
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 16, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8679

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-9258)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42168 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8641-t9258-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9388

@yadvr yadvr modified the milestones: 4.18.3, 4.19.1.0 Apr 30, 2024
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Apr 30, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-10098)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46380 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8641-t10098-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@yadvr yadvr merged commit fcfa371 into apache:4.18 Jun 24, 2024
@DaanHoogland DaanHoogland deleted the 4.18-kvm-compatible-oses branch June 24, 2024 18:39
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
* kvm: support Rocky/RHEL/OL/Alma in the same cluster

* Update PR#8641: add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

After upgrade from 4.18.0 to 4.18.1 cloudstack-agent not starting

6 participants