Skip to content

UI: fix permission of VNF appliances#8668

Merged
weizhouapache merged 1 commit intoapache:4.19from
weizhouapache:4.19-ui-fix-vnf-apps-permission
Feb 27, 2024
Merged

UI: fix permission of VNF appliances#8668
weizhouapache merged 1 commit intoapache:4.19from
weizhouapache:4.19-ui-fix-vnf-apps-permission

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

This PR fixes #8666

There is no API for listing VNF appliances, use listVnfTemplates as a workaround.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f86c62e) 30.90% compared to head (3dcfc9e) 30.89%.
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19    #8668      +/-   ##
============================================
- Coverage     30.90%   30.89%   -0.01%     
+ Complexity    34188    34179       -9     
============================================
  Files          5347     5347              
  Lines        375567   375578      +11     
  Branches      54626    54629       +3     
============================================
- Hits         116065   116048      -17     
- Misses       244232   244262      +30     
+ Partials      15270    15268       -2     
Flag Coverage Δ
simulator-marvin-tests 24.75% <ø> (-0.01%) ⬇️
uitests 4.39% <ø> (ø)
unit-tests 16.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Copy Markdown
Member Author

this has been tested by @dataCobra
#8666 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

VNF appliances entry in menu does not disappear when VNF is completely denied for a role

2 participants