Skip to content

Improve some UserVmManagerImpl's methods name and docs#8673

Merged
weizhouapache merged 1 commit intoapache:mainfrom
GutoVeronezi:improve-methods-doc-and-name
Feb 19, 2024
Merged

Improve some UserVmManagerImpl's methods name and docs#8673
weizhouapache merged 1 commit intoapache:mainfrom
GutoVeronezi:improve-methods-doc-and-name

Conversation

@GutoVeronezi
Copy link
Copy Markdown
Contributor

Description

This PR renames some UserVmManagerImpl's methods and improve their javadocs to make them more intuitive.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@GutoVeronezi
Copy link
Copy Markdown
Contributor Author

@GaOrtiga @weizhouapache I did some improvements to the methods names and javadocs in order to avoid confusion in the future.

@GutoVeronezi
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6af1c25) 30.79% compared to head (247534f) 30.79%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8673   +/-   ##
=========================================
  Coverage     30.79%   30.79%           
- Complexity    33115    33123    +8     
=========================================
  Files          5353     5353           
  Lines        374626   374626           
  Branches      54642    54642           
=========================================
+ Hits         115358   115369   +11     
- Misses       243942   243966   +24     
+ Partials      15326    15291   -35     
Flag Coverage Δ
simulator-marvin-tests 24.67% <57.14%> (+<0.01%) ⬆️
uitests 4.38% <ø> (ø)
unit-tests 16.43% <85.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8707

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Copy Markdown
Contributor

@GaOrtiga GaOrtiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarifications.

CLTM.

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Copy Markdown
Member

Merging as this just renames some methods.

@weizhouapache weizhouapache merged commit 8f6721e into apache:main Feb 19, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Feb 23, 2024
Co-authored-by: Daniel Augusto Veronezi Salvador <gutoveronezi@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants