Improve some UserVmManagerImpl's methods name and docs#8673
Improve some UserVmManagerImpl's methods name and docs#8673weizhouapache merged 1 commit intoapache:mainfrom
Conversation
|
@GaOrtiga @weizhouapache I did some improvements to the methods names and javadocs in order to avoid confusion in the future. |
|
@blueorangutan package |
|
@GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8673 +/- ##
=========================================
Coverage 30.79% 30.79%
- Complexity 33115 33123 +8
=========================================
Files 5353 5353
Lines 374626 374626
Branches 54642 54642
=========================================
+ Hits 115358 115369 +11
- Misses 243942 243966 +24
+ Partials 15326 15291 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8707 |
GaOrtiga
left a comment
There was a problem hiding this comment.
Good clarifications.
CLTM.
|
Merging as this just renames some methods. |
Co-authored-by: Daniel Augusto Veronezi Salvador <gutoveronezi@apache.org>
Description
This PR renames some
UserVmManagerImpl's methods and improve their javadocs to make them more intuitive.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?