field enlarged and db upgrade

[DaanHoogland]

Description

This PR...

Fixes: #8669

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 30.98%. Comparing base (6c6023b) to head (b38648f).

Files	Patch %	Lines
...ava/com/cloud/upgrade/dao/Upgrade41900to41910.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8675      +/-   ##
============================================
+ Coverage     30.13%   30.98%   +0.84%     
- Complexity    33072    34372    +1300     
============================================
  Files          5355     5355              
  Lines        376690   376690              
  Branches      54815    54815              
============================================
+ Hits         113533   116718    +3185     
+ Misses       248185   244581    -3604     
- Partials      14972    15391     +419     

Flag	Coverage Δ
simulator-marvin-tests	24.84% <0.00%> (+1.16%)	⬆️
uitests	4.38% <ø> (ø)
unit-tests	16.57% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weizhouapache]

@DaanHoogland
there are several UnusedImports

[DaanHoogland]

@weizhouapache there is another PR out that also adds the 4.19.0 to 4.19.1 upgrade path #8591 so I was waiting for that to be merged, but it has an error in a library:
https://github.com/apache/cloudstack/actions/runs/7971971809/job/21762739407?pr=8591#step:10:9596

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[weizhouapache]

@DaanHoogland

        final String scriptFile = "META-INF/db/schema-41900to41910.sql";

[DaanHoogland]

@DaanHoogland

        final String scriptFile = "META-INF/db/schema-41900to41910.sql";

yes?

[weizhouapache]

@DaanHoogland

        final String scriptFile = "META-INF/db/schema-41900to41910.sql";

yes?

The new file in this PR is
engine/schema/src/main/resources/META-INF/db/schema-41900-41910.sql

Not 41900 "to" 41910

@DaanHoogland

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 16.37%. Comparing base (49d244f) to head (02b0df4).
Report is 1 commits behind head on 4.19.

Files	Patch %	Lines
...ava/com/cloud/upgrade/dao/Upgrade41900to41910.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8675      +/-   ##
============================================
+ Coverage     16.23%   16.37%   +0.14%     
- Complexity    14546    14620      +74     
============================================
  Files          4867     4867              
  Lines        326209   326209              
  Branches      45855    45855              
============================================
+ Hits          52947    53422     +475     
+ Misses       265786   265143     -643     
- Partials       7476     7644     +168     

Flag	Coverage Δ
simulator-marvin-tests	16.37% <0.00%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weizhouapache]

code lgm

@DaanHoogland
lint error

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sureshanaparti]

Verified column update query, LGTM

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9359

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9949)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52880 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8675-t9949-kvm-centos7.zip
Smoke tests completed. 125 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	293.82	test_events_resource.py
test_01_events_resource	Error	293.83	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Failure	84.65	test_network_permissions.py
ContextSuite context=TestNetworkPermissions>:teardown	Error	1.46	test_network_permissions.py
test_01_secure_vm_migration	Error	133.78	test_vm_life_cycle.py
test_01_secure_vm_migration	Error	133.79	test_vm_life_cycle.py
test_02_unsecure_vm_migration	Error	0.02	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	0.02	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	Error	0.02	test_vm_life_cycle.py
test_02_redundant_VPC_default_routes	Failure	1900.56	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Failure	715.11	test_vpc_redundant.py
test_05_rvpc_multi_tiers	Error	715.13	test_vpc_redundant.py

[sureshanaparti]

Merging this based on LGTMs / tests.