Sync the storage pool stats in DB with the actual stats from stats collector

[sureshanaparti]

Description

This PR syncs the pool stats in DB with the actual stats from stats collector if there are any discrepancies with in-memory or DB stats - both capacity (disksizetotal) and used (disksizeused) bytes.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Checked the pool stats after updating capacitybytes for the pool - DB sync-ed with the actual capacitybytes from stats collector.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1a11311) 30.90% compared to head (288b674) 30.87%.

Files	Patch %	Lines
...src/main/java/com/cloud/server/StatsCollector.java	22.22%	3 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #8686      +/-   ##
============================================
- Coverage     30.90%   30.87%   -0.04%     
+ Complexity    34202    34182      -20     
============================================
  Files          5347     5347              
  Lines        375621   375625       +4     
  Branches      54627    54629       +2     
============================================
- Hits         116093   115964     -129     
- Misses       244240   244396     +156     
+ Partials      15288    15265      -23     

Flag	Coverage Δ
simulator-marvin-tests	24.74% <22.22%> (-0.01%)	⬇️
uitests	4.39% <ø> (ø)
unit-tests	16.57% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[weizhouapache]

code lgtm

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ debian. SL-JID 8730

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8731

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9315)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44620 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8686-t9315-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

clgtm

[borisstoyanov]

LGTM