Skip to content

Fixed deleteVlanIpRange API description#8700

Merged
shwstppr merged 1 commit intoapache:4.19from
OlegChuev:fix/delete-vlan-ip-range-description-fix
Feb 26, 2024
Merged

Fixed deleteVlanIpRange API description#8700
shwstppr merged 1 commit intoapache:4.19from
OlegChuev:fix/delete-vlan-ip-range-description-fix

Conversation

@OlegChuev
Copy link
Copy Markdown
Contributor

Description

This PR updates deleteVlanIpRange API description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

Awaiting build. GHA should be enough for this one.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.94%. Comparing base (88ff77d) to head (09b4713).
Report is 697 commits behind head on 4.19.

Additional details and impacted files
@@              Coverage Diff              @@
##               4.19    #8700       +/-   ##
=============================================
+ Coverage     12.93%   30.94%   +18.00%     
- Complexity     8944    34247    +25303     
=============================================
  Files          2715     5347     +2632     
  Lines        256107   375613   +119506     
  Branches      39938    54627    +14689     
=============================================
+ Hits          33139   116247    +83108     
- Misses       218808   244060    +25252     
- Partials       4160    15306    +11146     
Flag Coverage Δ
simulator-marvin-tests 24.83% <ø> (?)
uitests 4.39% <ø> (?)
unit-tests 16.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr shwstppr merged commit 3aafb28 into apache:4.19 Feb 26, 2024
@OlegChuev OlegChuev deleted the fix/delete-vlan-ip-range-description-fix branch February 26, 2024 07:04
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 5, 2024
Updates deleteVlanIpRange API description
@DaanHoogland DaanHoogland added this to the 4.19.1.0 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants