[UI] Allow detach ISO from instance toolbar when ISO is attached#8716
Merged
DaanHoogland merged 1 commit intoapache:4.18from Mar 4, 2024
Merged
Conversation
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.18 #8716 +/- ##
=========================================
Coverage 13.16% 13.16%
Complexity 9203 9203
=========================================
Files 2724 2724
Lines 258130 258130
Branches 40232 40232
=========================================
Hits 33989 33989
Misses 219833 219833
Partials 4308 4308 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Feb 28, 2024
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, tested in qa
JoaoJandre
approved these changes
Feb 28, 2024
Contributor
JoaoJandre
left a comment
JoaoJandre
left a comment
There was a problem hiding this comment.
CLGTM, also tested in QA
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows detach ISO from instance toolbar when ISO is attached.
Fixes #8711
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Manually tested attach & detach ISO from instance toolbar.
How did you try to break this feature and the system with this change?