Support KVM storage implementations controlling logical/physical block io size#8724
Support KVM storage implementations controlling logical/physical block io size#8724yadvr merged 2 commits intoapache:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8724 +/- ##
============================================
- Coverage 30.97% 30.96% -0.01%
+ Complexity 33481 33478 -3
============================================
Files 5355 5355
Lines 375830 375855 +25
Branches 54895 54899 +4
============================================
- Hits 116414 116400 -14
- Misses 243974 244034 +60
+ Partials 15442 15421 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8814 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8816 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-9347)
|
|
Hi @mlsorensen can this be targeted for 4.19.1? |
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, based on code review and test results from marvin
…k io size (apache#8724) * Support KVM storage implementations controlling logical/physical block io size * Support custom block size during disk attach --------- Co-authored-by: Marcus Sorensen <mls@apple.com>
5 participants
Description
This PR allows a given KVM storage implementation to decide if it wants to override the Libvirt disk XML's physical/logical IO size. For now all in-tree implementations will default to not using this.
In the future it may also be possible to extend the disk offerings to provide more granular control.
Note that using a logical sector size other than 512 would require the image to be built to support it, so this may be better suited as a property of the image at some point. Physical sector size can be changed as desired. This at least puts the XML definitions in place as a start.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
Tested locally by modifying an in-tree plugin, but didn't commit that change to avoid changing upstream behavior.
Also added unit test to test XML generation.