linstor: cleanup diskless nodes on disconnect

[rp-]

Description

If disconnect is running on a diskless node, try to cleanup the resource.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Moving/Stopping resources on a hyperconverged and non hyperconverged linstor cluster

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 13.16%. Comparing base (f8fd22c) to head (af48a83).
Report is 3 commits behind head on 4.18.

Files	Patch %	Lines
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java	0.00%	41 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.18    #8790      +/-   ##
============================================
- Coverage     13.16%   13.16%   -0.01%     
+ Complexity     9205     9203       -2     
============================================
  Files          2724     2724              
  Lines        258149   258170      +21     
  Branches      40235    40240       +5     
============================================
- Hits          33987    33982       -5     
- Misses       219856   219883      +27     
+ Partials       4306     4305       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

clgtm

[sureshanaparti]

code lgtm

[sureshanaparti]

@blueorangutan package

[rp-]

@DaanHoogland
Is this planned for 4.18.2.0?
As described, if not, this will introduce a bug with disconnectPhysicalDiskByPath for other storage providers

[DaanHoogland]

@JoaoJandre , as @rp- describes this will prevent a bug being introduced. Can we add it to 4.18.2?

[JoaoJandre]

@JoaoJandre , as @rp- describes this will prevent a bug being introduced. Can we add it to 4.18.2?

@DaanHoogland sure, but some third party testing would be good.

[rp-]

@JoaoJandre , as @rp- describes this will prevent a bug being introduced. Can we add it to 4.18.2?

@DaanHoogland sure, but some third party testing would be good.

Anyway I can help here?

[DaanHoogland]

@JoaoJandre , as @rp- describes this will prevent a bug being introduced. Can we add it to 4.18.2?

@DaanHoogland sure, but some third party testing would be good.

Anyway I can help here?

@rp- , I have no way to test this (i think). @JoaoJandre do you use linstor?

[JoaoJandre]

@JoaoJandre , as @rp- describes this will prevent a bug being introduced. Can we add it to 4.18.2?

@DaanHoogland sure, but some third party testing would be good.

Anyway I can help here?

@rp- , I have no way to test this (i think). @JoaoJandre do you use linstor?

@rp- are you the only known linstor developer/user? @DaanHoogland do you know if we have anyone else in the community that works with linstor?

[rp-]

@JoaoJandre , as @rp- describes this will prevent a bug being introduced. Can we add it to 4.18.2?

@DaanHoogland sure, but some third party testing would be good.

Anyway I can help here?

@rp- , I have no way to test this (i think). @JoaoJandre do you use linstor?

@rp- are you the only known linstor developer/user? @DaanHoogland do you know if we have anyone else in the community that works with linstor?

I'm for sure the only Linstor-plugin dev, but we have some customers and I know Rohit has a Linstor cluster at home, but I guess already at 4.19...

[DaanHoogland]

@JoaoJandre , as @rp- describes this will prevent a bug being introduced. Can we add it to 4.18.2?

@DaanHoogland sure, but some third party testing would be good.

Anyway I can help here?

@rp- , I have no way to test this (i think). @JoaoJandre do you use linstor?

@rp- are you the only known linstor developer/user? @DaanHoogland do you know if we have anyone else in the community that works with linstor?

I'm for sure the only Linstor-plugin dev, but we have some customers and I know Rohit has a Linstor cluster at home, but I guess already at 4.19...

@Rohit, can you have a look at this?

[JoaoJandre]

@JoaoJandre , as @rp- describes this will prevent a bug being introduced. Can we add it to 4.18.2?

@DaanHoogland sure, but some third party testing would be good.

Anyway I can help here?

@rp- , I have no way to test this (i think). @JoaoJandre do you use linstor?

@rp- are you the only known linstor developer/user? @DaanHoogland do you know if we have anyone else in the community that works with linstor?

I'm for sure the only Linstor-plugin dev, but we have some customers and I know Rohit has a Linstor cluster at home, but I guess already at 4.19...

@Rohit, can you have a look at this?

@DaanHoogland I think you meant @rohityadavcloud, right?

[JoaoJandre]

@blueorangutan package

[blueorangutan]

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9196

[JoaoJandre]

@DaanHoogland can we run the CI here?

[DaanHoogland]

@blueorangutan test alma9 kvm-alma9

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-9761)

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9255

[DaanHoogland]

@blueorangutan test alma9 kvm-alma9

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9832)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 43639 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8790-t9832-kvm-alma9.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[rp-]

I have fixed a NPE if the device paths had been null (reported from Linstor, because a node was down)

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9295

[DaanHoogland]

@blueorangutan test alma9 kvm-alma9

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-9885)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 49564 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8790-t9885-kvm-alma9.zip
Smoke tests completed. 108 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_attach_and_distribute_multiple_volumes	Failure	27.44	test_attach_multiple_volumes.py
test_01_migrate_VM_and_root_volume	Error	94.66	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	52.87	test_vm_life_cycle.py
test_08_migrate_vm	Error	47.27	test_vm_life_cycle.py

[rp-]

@DaanHoogland can we merge this now?

[DaanHoogland]

@rp- , this is causing some conflicts in merge forward. Can you advise how tryDisconnectLinstor should be implemented in main?

I think I know but please review in main once I have pushed.

[rp-]

@rp- , this is causing some conflicts in merge forward. Can you advise how tryDisconnectLinstor should be implemented in main?

I think I know but please review in main once I have pushed.

I put the cherry-picked/resolved here: https://github.com/LINBIT/cloudstack/tree/linstor-main-cleanup-diskless

[DaanHoogland]

I think I got it right and running a test compile now. if that passes , I'll push.