Skip to content

Support Projects in Userdata#9373

Closed
Pearl1594 wants to merge 1 commit into4.19from
ud-support-proj
Closed

Support Projects in Userdata#9373
Pearl1594 wants to merge 1 commit into4.19from
ud-support-proj

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

Description

This PR attempts to fix ##9332

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 12.26%. Comparing base (beebeed) to head (8410707).
Report is 857 commits behind head on 4.19.

Files with missing lines Patch % Lines
...src/main/java/com/cloud/api/ApiResponseHelper.java 0.00% 7 Missing ⚠️
...ache/cloudstack/api/response/UserDataResponse.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               4.19    #9373    +/-   ##
==========================================
  Coverage     12.25%   12.26%            
- Complexity     9318     9321     +3     
==========================================
  Files          4699     4699            
  Lines        414601   414612    +11     
  Branches      51421    51054   -367     
==========================================
+ Hits          50829    50842    +13     
+ Misses       357461   357457     -4     
- Partials       6311     6313     +2     
Flag Coverage Δ
unittests 12.26% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jul 11, 2024

@Pearl1594
alternatively we could backport #8656 to 4.18

some UI changes in this PR are still valid

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Oh my bad - I didn't realize there was a fix on 4.19 - explains why we haven't been able to reproduce on 4.19 envs :D cc @DaanHoogland

@Pearl1594
Copy link
Copy Markdown
Contributor Author

I shall update this .. Thanks @weizhouapache

@yadvr yadvr changed the base branch from 4.18 to 4.19 October 17, 2024 09:19
@yadvr yadvr added this to the 4.19.2.0 milestone Oct 17, 2024
@github-actions
Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Pearl1594 commented Jan 24, 2025

Issue seems to be fixed in 4.19.1 by: #8656. PR no longer needed

@Pearl1594 Pearl1594 closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants