Skip to content

[NET-741] Add subnet IPv6 handling#391

Open
see-quick wants to merge 2 commits intoapache:masterfrom
see-quick:add-ipv6-subnet-utils
Open

[NET-741] Add subnet IPv6 handling#391
see-quick wants to merge 2 commits intoapache:masterfrom
see-quick:add-ipv6-subnet-utils

Conversation

@see-quick
Copy link

This PR adds SubnetUtils6 to also support IPv6 CIDR notation, as the end user could possibly need handling not just the IPv4 stack. Moreover, I have added tests to cover this functionality accordingly.

Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick
Copy link
Author

Since there hasn't been much feedback so far... I want to ask whether this approach is okay or if you prefer a different direction?

cc @garydgregory or other maintainers @sebbASF ?

@isaric
Copy link

isaric commented Jan 21, 2026

Hey @see-quick , is there a JIRA issue for this PR?
If yes, please include the tag in the title of the PR. You should also include the tag in the commits.
If there is no issue, you should write one and get the issue reviewed. After that, you can include the tag here and the PR can be reviewed.

@garydgregory
Copy link
Member

Since there hasn't been much feedback so far... I want to ask whether this approach is okay or if you prefer a different direction?

cc @garydgregory or other maintainers @sebbASF ?

I'll try take a look this week...

@see-quick
Copy link
Author

see-quick commented Feb 9, 2026

Hi, I have opened the KIP-1276 , which is currently under discussion. This change helps enable the functionality described in the KIP. I appreciate your time and feedback.

@see-quick see-quick changed the title Add SubnetUtils6 [NET-741] Add subnet IPv6 handling Feb 18, 2026
@garydgregory
Copy link
Member

The Jira ticket is https://issues.apache.org/jira/browse/NET-741

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @see-quick

I'm sorry I haven't commented here for a while.

I think it would be nice to have a test class or method that specifically tests all the examples in https://datatracker.ietf.org/doc/html/rfc5952

The Javadoc should also point to the RFC.

return new SubnetInfo();
}

@Override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a Javadoc to describe the format. Is there an expectation that this string can be fed back in the constructor? Either way, testToString should test that use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments