Open
Conversation
rnewson
approved these changes
Oct 3, 2018
3 tasks
Contributor
|
Noticed there was another ibrowse commit after that which fixed an issue related to ipv6 being the new default: Wonder if we'd need that as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
presently it's not possible to use ibrowse client (e.g. during replication) for
inet6-only hosts as the pattern match returned is insufficient. This patch
pulls in upstream's cmullaparthi/ibrowse@555f7074
minimal diff.
The patch will also require tagging so we can pull it into the main couchdb
tree, I've suggested CouchDB-4.0.2 which doesn't quite line up with the
history from ibrowse but it seems sensible enough.