bug: Fix string decimal type throw right exception #3248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
reviewed
Jan 22, 2026
andygrove
reviewed
Jan 22, 2026
| withSQLConf(CometConf.getExprAllowIncompatConfigKey(classOf[Cast]) -> "true") { | ||
| // TODO fix for Spark 4.0.0 | ||
| assume(!isSpark40Plus) | ||
| println("testing with simple input") |
Member
There was a problem hiding this comment.
the debug logging should be removed
Contributor
Author
There was a problem hiding this comment.
Thank you. I will update and remove debug statements
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3248 +/- ##
============================================
- Coverage 56.12% 54.95% -1.17%
- Complexity 976 1387 +411
============================================
Files 119 170 +51
Lines 11743 15777 +4034
Branches 2251 2604 +353
============================================
+ Hits 6591 8671 +2080
- Misses 4012 5868 +1856
- Partials 1140 1238 +98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Root cause for test failures :
|
coderfender
force-pushed
the
fix_string_decimal_type_error_bug
branch
from
de1618a to
a9b9ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?