Fix hour/minute/second handling for TimestampNTZ #3265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3180
Rationale for this change
Spark
TimestampNTZvalues represent local time without any timezoneinformation. However, the current Comet implementation applies timezone
conversion when evaluating
hour,minute, andsecond, which leads toincorrect results for
TimestampNTZinputs in non-UTC session timezones.This change aligns Comet behavior with Spark semantics by ensuring that
timezone conversion is only applied to
Timestampvalues with an explicittimezone, and not to
TimestampNTZ.What changes are included in this PR?
extract_date_partused byhour,minute, andsecondto:TimestampNTZinputsTimestampinputs with timezoneHow are these changes tested?
cargo test -p datafusion-comet-spark-expr