[JDO-709] Enable Element.TYPE for @Convert - TCK test#61
Open
[JDO-709] Enable Element.TYPE for @Convert - TCK test#61
Conversation
This reverts commit bddffab to be consistent with its javadoc. With this capability, we can avoid as much configuration file as possible, it's very convenient to mark default attribute converter for a type with Java annotation. Reference: https://issues.apache.org/jira/browse/JDO-709?focusedCommentId=17619585&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17619585
|
SonarCloud Quality Gate failed.
|
Contributor
Author
|
I filed a ticket for the Datanucleus reference implementation: datanucleus/datanucleus-api-jdo#127 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on PR #60 . This PR adds
@Converttests to thePointAttributeConverterTestin the TCK.The convertible point class is called
ConvertiblePointand is used in a new persistent class isPCRectPointTypeAnnotated.Questions:
.jdoor.ormfiles?ConvertiblePointfields inPCRectPointTypeAnnotated?Current status: The test fails. It appears that the converter is not called.
dsid-converter-junit.txt
dsid-converter-tck.txt