Adding new JDBC types. Notifying but not failing during model reading#1
Open
mohdaliiqbal wants to merge 1 commit intoapache:trunkfrom
Open
Adding new JDBC types. Notifying but not failing during model reading#1mohdaliiqbal wants to merge 1 commit intoapache:trunkfrom
mohdaliiqbal wants to merge 1 commit intoapache:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some new JDBC types which are causing the new MS SQL server driver to fail while reading model.
Plus I have added exception catching/printing stacktrace instead of failing. -- this part was useful in my case, i can remove this from PR if you think it is inappropriate handling.