Skip to content

[Improvement-18441][API&DAO] Optimize TaskInstanceMapper to exclude large text fields from list queries #18442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njnu-seafish wants to merge 5 commits into
base: dev
Choose a base branch
from
+17 −5
Open

[Improvement-18441][API&DAO] Optimize TaskInstanceMapper to exclude large text fields from list queries #18442

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ccdb06
optimize TaskInstanceMapper to exclude large text fields from list qu…
Jul 24, 2026
30040dd
revert critical queries to use baseSql for failover compatibility
Jul 27, 2026
c542b41
remove listSqlV2
Jul 27, 2026
e3bf259
exclude large text fields from queryByInstanceIdAndCode and findLastT…
Jul 27, 2026
726003a
Merge branch 'dev' into Improvement-18441
njnu-seafish Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions ...uler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,18 @@
${alias}.flag, ${alias}.retry_interval, ${alias}.max_retry_times, ${alias}.task_instance_priority, ${alias}.worker_group,${alias}.environment_code , ${alias}.executor_id,
${alias}.first_submit_time, ${alias}.delay_time, ${alias}.task_params, ${alias}.var_pool, ${alias}.dry_run, ${alias}.task_group_id, ${alias}.task_execute_type
</sql>
<sql id="listSql">
id, name, task_type, workflow_instance_id, workflow_instance_name, project_code, task_code, task_definition_version, state, submit_time,
start_time, end_time, host, alert_flag, retry_times, pid,
flag, retry_interval, max_retry_times, task_instance_priority, worker_group,environment_code , executor_id, executor_name,
first_submit_time, delay_time, dry_run, task_group_id, cpu_quota, memory_max, task_execute_type
</sql>
<sql id="listSqlV2">
${alias}.id, ${alias}.name, ${alias}.task_type, ${alias}.workflow_instance_id, ${alias}.workflow_instance_name, ${alias}.project_code, ${alias}.task_code, ${alias}.task_definition_version, ${alias}.state, ${alias}.submit_time,
${alias}.start_time, ${alias}.end_time, ${alias}.host, ${alias}.alert_flag, ${alias}.retry_times, ${alias}.pid,
${alias}.flag, ${alias}.retry_interval, ${alias}.max_retry_times, ${alias}.task_instance_priority, ${alias}.worker_group, ${alias}.environment_code, ${alias}.executor_id, ${alias}.executor_name,
${alias}.first_submit_time, ${alias}.delay_time, ${alias}.dry_run, ${alias}.task_group_id, ${alias}.cpu_quota, ${alias}.memory_max, ${alias}.task_execute_type
</sql>
<select id="findValidTaskListByWorkflowInstanceId" resultType="org.apache.dolphinscheduler.dao.entity.TaskInstance">
select
<include refid="baseSql"/>
Expand Down Expand Up @@ -125,7 +137,7 @@

<select id="queryByInstanceIdAndCode" resultType="org.apache.dolphinscheduler.dao.entity.TaskInstance">
select
<include refid="baseSql"/>
<include refid="listSql"/>
from t_ds_task_instance
where workflow_instance_id = #{workflowInstanceId}
and task_code = #{taskCode}
Expand All @@ -134,7 +146,7 @@
</select>
<select id="queryByWorkflowInstanceIdsAndTaskCodes" resultType="org.apache.dolphinscheduler.dao.entity.TaskInstance">
select
<include refid="baseSql"/>
<include refid="listSql"/>
from t_ds_task_instance
where flag = 1
<if test="workflowInstanceIds != null and workflowInstanceIds.size() != 0">
Expand All @@ -153,7 +165,7 @@

<select id="queryTaskInstanceListPaging" resultType="org.apache.dolphinscheduler.dao.entity.TaskInstance">
select
<include refid="baseSql"/>
<include refid="listSql"/>
from t_ds_task_instance
where project_code = #{projectCode}
<if test="startTime != null">
Expand Down Expand Up @@ -196,7 +208,7 @@
</select>
<select id="queryStreamTaskInstanceListPaging" resultType="org.apache.dolphinscheduler.dao.entity.TaskInstance">
select
<include refid="baseSql"/>
<include refid="listSql"/>
from t_ds_task_instance
where project_code = #{projectCode}
<if test="startTime != null">
Expand Down Expand Up @@ -236,7 +248,7 @@
</select>
<select id="findLastTaskInstances" resultType="org.apache.dolphinscheduler.dao.entity.TaskInstance">
select
<include refid="baseSqlV2">
<include refid="listSqlV2">
<property name="alias" value="instance"/>
</include>
from t_ds_task_instance instance
Expand Down
Loading