Skip to content

[kudu] fix write priv issue #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Feb 6, 2026
Merged

[kudu] fix write priv issue #379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
909b6ba
[kudu] do not use write
morningman Feb 5, 2026
b8bc2d5
[kudu] fix write priv issue
morningman Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 6 additions & 38 deletions ...-kudu/src/main/java/io/trino/plugin/kudu/schema/SchemaEmulationByTableNameConvention.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,9 @@
import org.apache.kudu.client.Delete;
import org.apache.kudu.client.KuduException;
import org.apache.kudu.client.KuduOperationApplier;
import org.apache.kudu.client.KuduScanner;
import org.apache.kudu.client.KuduTable;
import org.apache.kudu.client.RowResult;
import org.apache.kudu.client.RowResultIterator;
import org.apache.kudu.client.Upsert;

import java.util.ArrayList;
import java.util.LinkedHashSet;
import java.util.List;

Expand Down Expand Up @@ -113,40 +109,12 @@ public void dropSchema(KuduClientWrapper client, String schemaName, boolean casc
public List<String> listSchemaNames(KuduClientWrapper client)
{
try {
if (rawSchemasTable == null) {
// Try to open the schemas table first, only create if it doesn't exist
try {
rawSchemasTable = client.openTable(rawSchemasTableName);
}
catch (KuduException e) {
if (e.getStatus().isNotFound()) {
// Table doesn't exist, try to create it (requires write permission)
// If creation fails due to permission, fall back to scanning table names
try {
createAndFillSchemasTable(client);
rawSchemasTable = getSchemasTable(client);
}
catch (KuduException createException) {
// Fall back to listing schemas from table names directly (read-only)
return listSchemaNamesFromTablets(client);
}
}
else {
throw e;
}
}
}

KuduScanner scanner = client.newScannerBuilder(rawSchemasTable).build();
RowResultIterator iterator = scanner.nextRows();
ArrayList<String> result = new ArrayList<>();
while (iterator != null) {
for (RowResult row : iterator) {
result.add(row.getString(0));
}
iterator = scanner.nextRows();
}
return result;
// createAndFillSchemasTable(client);
// rawSchemasTable = getSchemasTable(client);
// ATTN, sometimes user does not have write priv for kudu,
// so we can not create schema table here.
// So here we get schema names directly from tablets.
return listSchemaNamesFromTablets(client);
}
catch (KuduException e) {
throw new TrinoException(GENERIC_INTERNAL_ERROR, e);
Expand Down