Skip to content

[branch-4.1] Fix meta tool build#63371

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
gavinchou:fix-branch-4.1-compile
May 19, 2026
Merged

[branch-4.1] Fix meta tool build#63371
yiguolei merged 1 commit into
apache:branch-4.1from
gavinchou:fix-branch-4.1-compile

Conversation

@gavinchou
Copy link
Copy Markdown
Contributor

@gavinchou gavinchou commented May 18, 2026

#63540

Proposed changes

Fix meta_tool build on branch-4.1 by:

  • adding the repository root include path for meta_tool so common/cpp/private_member_accessor.hpp can be resolved
  • qualifying Doris types in meta_tool.cpp
  • fixing private member pointer access through ExecEnv*

Testing

  • sh format_code.sh be/src/tools/meta_tool.cpp
  • sh build.sh --be --meta-tool -j100

@gavinchou gavinchou requested a review from yiguolei as a code owner May 18, 2026 16:27
@hello-stephen
Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit b10073a into apache:branch-4.1 May 19, 2026
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants