[fix](variant) preserve TIMESTAMPTZ values in sparse path#63522
Open
csun5285 wants to merge 1 commit into
Open
[fix](variant) preserve TIMESTAMPTZ values in sparse path#63522csun5285 wants to merge 1 commit into
csun5285 wants to merge 1 commit into
Conversation
DataTypeTimeStampTzSerDe inherited DataTypeNumberSerDe's default write_one_cell_to_binary, which emits [type:1][value:8]. The matching reader branch in DataTypeNumberSerDe<TYPE_TIMESTAMPTZ>::deserialize_binary_to_* skips a scale byte before reading the value, expecting [type:1][scale:1][value:8]. The 1-byte layout mismatch shifted every read by one byte, leaving only the timezone-offset bits intact, so CAST(var['ts'] AS string) on a variant typed path that fell to sparse returned just "+08:00" (DORIS-25915). Add the missing write_one_cell_to_binary override mirroring DataTypeDateTimeV2SerDe so the writer also emits the scale byte. Reader is already correct. Tests: - regression-test/suites/variant_p0/test_variant_timestamptz_sparse.groovy reproduces the Jira repro (typed paths > variant_max_subcolumns_count with variant_enable_typed_paths_to_sparse=true) and asserts the read value contains the date portion. - BE UT data_type_serde_timestamptz_test.cpp adds binary_roundtrip covering scale=0/3/6, checking the 10-byte layout and roundtrip via both DataTypeSerDe::deserialize_binary_to_column and ::deserialize_binary_to_field. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
TPC-H: Total hot run time: 31308 ms |
Contributor
TPC-DS: Total hot run time: 169416 ms |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing write_one_cell_to_binary override mirroring DataTypeDateTimeV2SerDe so the writer also emits the scale byte. Reader is already correct.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)