branch-4.0: [chore](http) Merge ms and recycler http skeleton #61502 #63051 #60816#63527
Open
wyxxxcat wants to merge 3 commits into
Open
branch-4.0: [chore](http) Merge ms and recycler http skeleton #61502 #63051 #60816#63527wyxxxcat wants to merge 3 commits into
wyxxxcat wants to merge 3 commits into
Conversation
Problem Summary: Meta service and recycler maintained duplicated HTTP
parsing, routing, and config handling logic, which made it harder to
reuse handlers and keep versioned endpoints consistent. This change
extracts the shared HTTP helper layer into `cloud/src/common/
http_helper.*`, introduces role-based handler registration for
MetaService and Recycler, reuses common config show/update helpers, and
adds versioned cluster HTTP test coverage.
If you want to expand the interface version
```
{"add_cluster",
{.handler = [](void* s, brpc::Controller* c) { return process_alter_cluster((MS*)s, c); },
.versioned_handlers =
{{"v2",
[](void* s, brpc::Controller* c) {
return process_alter_cluster_v2((MS*)s, c);
}}},
.role = HttpRole::META_SERVICE}},
```
…#63051) [fix](recycler) Recycler/Ms http api result msg should set ok Set successful Recycler/MS HTTP API messages to OK. The shared helper covers JSON/text success messages.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Collaborator
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick: #61502 #63051 #60816