branch-4.0: [fix](be) Poll packed file async close without blocking #62938#63531
Open
wyxxxcat wants to merge 1 commit into
Open
branch-4.0: [fix](be) Poll packed file async close without blocking #62938#63531wyxxxcat wants to merge 1 commit into
wyxxxcat wants to merge 1 commit into
Conversation
fix: apache#57770 This change adds a non-blocking try_finish_close() hook to FileWriter and implements it for S3FileWriter. PackedFileManager now polls the async close result instead of calling close(true) repeatedly while packed files are uploading. The change avoids re-submitting async close work and lets packed file upload state transition only after the previous async close has actually completed. It also propagates async close failures back into the packed file state so failed uploads are recorded correctly. A ut test was added to verify that PackedFileManager polls async close without blocking or issuing an extra close call, and that async close failures are handled as packed file upload failures.
Collaborator
Author
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick: #62938