[fix](job scheduler) Record task finish time on execution failure - #66232
Open
yujun777 wants to merge 1 commit into
Open
[fix](job scheduler) Record task finish time on execution failure#66232yujun777 wants to merge 1 commit into
yujun777 wants to merge 1 commit into
Conversation
Record the finish time when a task enters FAILED through the execution exception path, so MTMV failures expose complete terminal metadata and a usable duration. Key changes: - Set finishTimeMs in AbstractTask.onFail(). - Cover runTask() exception handling in AbstractJobStatusTest. Unit Test: - AbstractJobStatusTest: 13 tests passed.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
|
Add the PR that introduces the issue to the "related pr" section |
Contributor
TPC-H: Total hot run time: 29483 ms |
Contributor
TPC-DS: Total hot run time: 177248 ms |
Contributor
ClickBench: Total hot run time: 25.2 s |
CalvinKirs
approved these changes
Jul 29, 2026
Contributor
Author
|
run feut |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When a task fails through the execution exception path,
AbstractTask.runTask()calls the no-argumentonFail(), which marked the task FAILED without recordingfinishTimeMs. MTMV failed refresh tasks therefore exposed an empty FinishTime and could not calculate DurationMs.relate PR: #27703
What changes were made?
finishTimeMswhenAbstractTask.onFail()transitions a task to FAILED.runTask()exception path and preserving the error message.Testing
AbstractJobStatusTest: 13 tests passed.