Add sample Demonstrates Triple request metadata/attachments and response headers/trailers exposed through http.Header.#1112
Open
Alanxtl wants to merge 5 commits into
Open
Add sample Demonstrates Triple request metadata/attachments and response headers/trailers exposed through http.Header.#1112Alanxtl wants to merge 5 commits into
http.Header.#1112Alanxtl wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new triple_header_trailer sample that demonstrates using Dubbo-Go Triple metadata as http.Header, including sending request metadata and observing response headers/trailers via streaming APIs.
Changes:
- Add a new Go client/server sample showcasing Triple request metadata and stream response headers/trailers (
http.Headeraccessors likeValues). - Add new protobuf IDL and generated Go code for the sample.
- Register the sample in the root READMEs and the integration test sample list.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| triple_header_trailer/README.md | English documentation for running and understanding the new sample |
| triple_header_trailer/README_CN.md | Chinese documentation for running and understanding the new sample |
| triple_header_trailer/proto/greet.proto | Defines unary + streaming RPCs used to demonstrate metadata/header/trailer behavior |
| triple_header_trailer/proto/greet.pb.go | Generated protobuf types for the sample |
| triple_header_trailer/proto/greet.triple.go | Generated Triple client/server stubs exposing http.Header metadata APIs |
| triple_header_trailer/go-server/cmd/main.go | Server implementation reading incoming metadata and setting response headers/trailers |
| triple_header_trailer/go-client/cmd/main.go | Client implementation sending outgoing metadata and validating headers/trailers |
| start_integrate_test.sh | Adds the new sample to the full integration test run list |
| README.md | Adds the new sample to the repository sample index |
| README_CN.md | Adds the new sample to the repository sample index (Chinese) |
Files not reviewed (2)
- triple_header_trailer/proto/greet.pb.go: Generated file
- triple_header_trailer/proto/greet.triple.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexStocks
approved these changes
Jun 22, 2026
Member
Author
|
blocked by apache/dubbo-go#3446 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.