Skip to content

[config] Decouple config reader and remove config package#3449

Merged
AlexStocks merged 2 commits into
apache:developfrom
Alanxtl:delete
Jun 25, 2026
Merged

[config] Decouple config reader and remove config package#3449
AlexStocks merged 2 commits into
apache:developfrom
Alanxtl:delete

Conversation

@Alanxtl

@Alanxtl Alanxtl commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

Closing #3396 #3204 #2741

!! BREAKING CHANGE: Although dubbo-go does not use config internally any more, downstream users can use it directly. This will make it usable.

Checklist

  • I confirm the target branch is develop
  • Code has passed local testing
  • I have added tests that prove my fix is effective or that my feature works

@Alanxtl Alanxtl linked an issue Jun 22, 2026 that may be closed by this pull request
@Alanxtl

Alanxtl commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

@Snow-kal @CAICAIIs help review this

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.56%. Comparing base (60d1c2a) to head (62c832d).
⚠️ Report is 855 commits behind head on develop.

Files with missing lines Patch % Lines
common/extension/config_reader.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3449      +/-   ##
===========================================
+ Coverage    46.76%   53.56%   +6.79%     
===========================================
  Files          295      460     +165     
  Lines        17172    35182   +18010     
===========================================
+ Hits          8031    18846   +10815     
- Misses        8287    14856    +6569     
- Partials       854     1480     +626     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alanxtl

Alanxtl commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

ci fail 因为 dubbo-go-sample 依然依赖 config 已提pr修复 apache/dubbo-go-samples#1113

@CAICAIIs CAICAIIs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, cool work

Comment thread config/doc.go
@Alanxtl

Alanxtl commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

CI already pass

@Snow-kal

Copy link
Copy Markdown
Contributor

lgtm ♡

@AlexStocks AlexStocks merged commit 8b5bbcf into apache:develop Jun 25, 2026
10 of 11 checks passed
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Complete delete config package

5 participants