feat(triple): remove old triple IDL mode switch#3460
Draft
chaojixinren wants to merge 2 commits into
Draft
Conversation
* remove IDLMode / IDL / NONIDL constants and related client/server options * simplify triple Refer to always use the new triple invoker * delete old triple compat invoker dubbo3_invoker.go * decide IDL / non-IDL mode by the presence of ServiceInfo * update related tests
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3460 +/- ##
===========================================
+ Coverage 53.57% 54.85% +1.28%
===========================================
Files 460 454 -6
Lines 35182 34799 -383
===========================================
+ Hits 18847 19090 +243
+ Misses 14857 14213 -644
- Partials 1478 1496 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
ci 失败是因为 sample 还依赖 old triple |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes #3452
Based on #3451 (remove old triple implementation). With old triple (
protocol/dubbo3) removed, theIDLModecompatibility switch used to distinguish IDL / non-IDL mode is no longer needed. This PR removes it and keeps only the minimal mode semantics required by new Triple.Main changes:
IDLMode/IDL/NONIDLconstants and the relatedWithIDL/WithIDLModeoptions from client and serverIDLModeparam onto the service URLTripleProtocol.Referto always useNewTripleInvoker, and drop the old-tripleNewDubbo3Invokerpath and theisGenericCallhelperprotocol/triple/dubbo3_invoker.goServiceInfo(info != nil) instead of theIDLModeURL paramChecklist
develop