Closed
Conversation
…t-upstream-impact-e6i1zs 改进 LRU2Cache 的 `computeIfAbsent` 晋升逻辑
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16070 +/- ##
============================================
- Coverage 60.75% 60.75% -0.01%
- Complexity 11751 11753 +2
============================================
Files 1951 1951
Lines 88992 89008 +16
Branches 13418 13422 +4
============================================
+ Hits 54070 54077 +7
- Misses 29362 29369 +7
- Partials 5560 5562 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Fix the issue where RpcInvocation's copy constructor shares the same attributes map with the source invocation.
This causes cloned invocations to be affected by later mutations to the original attributes, which is unexpected for a deep clone.
The change clones the attributes map and adds a unit test to verify the behavior.
Fixes #16069
Checklist