Skip to content

[Optimization] Improve Zookeeper startup wait logic in StartZookeeperWindowsProcessor #16150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Senrian wants to merge 1 commit into
base: 3.3
Choose a base branch
from
+1 −84
Open

[Optimization] Improve Zookeeper startup wait logic in StartZookeeperWindowsProcessor #16150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 1 addition & 84 deletions .../org/apache/dubbo/test/check/registrycenter/processor/StartZookeeperWindowsProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,84 +1 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.dubbo.test.check.registrycenter.processor;

import org.apache.dubbo.common.logger.Logger;
import org.apache.dubbo.common.logger.LoggerFactory;
import org.apache.dubbo.test.check.exception.DubboTestException;
import org.apache.dubbo.test.check.registrycenter.Processor;
import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;

import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.concurrent.TimeUnit;

import org.apache.commons.exec.CommandLine;
import org.apache.commons.exec.DefaultExecutor;
import org.apache.commons.exec.Executor;

/**
* Create {@link Process} to start zookeeper on Windows OS.
*/
public class StartZookeeperWindowsProcessor extends ZookeeperWindowsProcessor {

private static final Logger logger = LoggerFactory.getLogger(StartZookeeperWindowsProcessor.class);

/**
* The {@link Processor} to find the pid of zookeeper instance.
*/
private final Processor findPidProcessor = new FindPidWindowsProcessor();

/**
* The {@link Processor} to kill the pid of zookeeper instance.
*/
private final Processor killPidProcessor = new KillProcessWindowsProcessor();

@Override
protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException {
// find pid and save into global context.
this.findPidProcessor.process(context);
// kill pid of zookeeper instance if exists
this.killPidProcessor.process(context);
for (int clientPort : context.getClientPorts()) {
logger.info(String.format("The zookeeper-%d is starting...", clientPort));
Path zookeeperBin = Paths.get(
context.getSourceFile().getParent().toString(),
String.valueOf(clientPort),
context.getUnpackedDirectory(),
"bin");
Executor executor = new DefaultExecutor();
executor.setExitValues(null);
executor.setWatchdog(context.getWatchdog());
CommandLine cmdLine = new CommandLine("cmd.exe");
cmdLine.addArgument("/c");
cmdLine.addArgument(Paths.get(zookeeperBin.toString(), "zkServer.cmd")
.toAbsolutePath()
.toString());
context.getExecutorService().submit(() -> executor.execute(cmdLine));
}
try {
// TODO: Help me to optimize the ugly sleep.
// sleep to wait all of zookeeper instances are started successfully.
// The best way is to check the output log with the specified keywords,
// however, there maybe keep waiting for check when any exception occurred,
// because the output stream will be blocked to wait for continuous data without any break
TimeUnit.SECONDS.sleep(3);
} catch (InterruptedException e) {
// ignored
}
}
}
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */package org.apache.dubbo.test.check.registrycenter.processor;import org.apache.dubbo.common.logger.Logger;import org.apache.dubbo.common.logger.LoggerFactory;import org.apache.dubbo.test.check.exception.DubboTestException;import org.apache.dubbo.test.check.registrycenter.Processor;import org.apache.dubbo.test.check.registrycenter.context.ZookeeperWindowsContext;import java.nio.file.Path;import java.nio.file.Paths;import java.util.concurrent.TimeUnit;import org.apache.commons.exec.CommandLine;import org.apache.commons.exec.DefaultExecutor;import org.apache.commons.exec.Executor;import org.apache.curator.framework.CuratorFramework;import org.apache.curator.framework.CuratorFrameworkFactory;import org.apache.curator.retry.RetryNTimes;/** * Create {@link Process} to start zookeeper on Windows OS. */public class StartZookeeperWindowsProcessor extends ZookeeperWindowsProcessor { private static final Logger logger = LoggerFactory.getLogger(StartZookeeperWindowsProcessor.class); /** * The {@link Processor} to find the pid of zookeeper instance. */ private final Processor findPidProcessor = new FindPidWindowsProcessor(); /** * The {@link Processor} to kill the pid of zookeeper instance. */ private final Processor killPidProcessor = new KillProcessWindowsProcessor(); @Override protected void doProcess(ZookeeperWindowsContext context) throws DubboTestException { // find pid and save into global context. this.findPidProcessor.process(context); // kill pid of zookeeper instance if exists this.killPidProcessor.process(context); for (int clientPort : context.getClientPorts()) { logger.info(String.format("The zookeeper-%d is starting...", clientPort)); Path zookeeperBin = Paths.get( context.getSourceFile().getParent().toString(), String.valueOf(clientPort), context.getUnpackedDirectory(), "bin"); Executor executor = new DefaultExecutor(); executor.setExitValues(null); executor.setWatchdog(context.getWatchdog()); CommandLine cmdLine = new CommandLine("cmd.exe"); cmdLine.addArgument("/c"); cmdLine.addArgument(Paths.get(zookeeperBin.toString(), "zkServer.cmd") .toAbsolutePath() .toString()); context.getExecutorService().submit(() -> executor.execute(cmdLine)); } // Wait for all zookeeper instances to be ready using Curator health check for (int clientPort : context.getClientPorts()) { try { CuratorFramework client = CuratorFrameworkFactory.builder() .connectString("127.0.0.1:" + clientPort) .retryPolicy(new RetryNTimes(1, 1000)) .build(); client.start(); boolean connected = client.blockUntilConnected(3, TimeUnit.SECONDS); client.close(); if (!connected) { throw new DubboTestException("Zookeeper instance on port " + clientPort + " failed to start within timeout"); } logger.info(String.format("The zookeeper-%d has started successfully.", clientPort)); } catch (InterruptedException e) { Thread.currentThread().interrupt(); throw new DubboTestException("Interrupted while waiting for zookeeper to start", e); } catch (Exception e) { throw new DubboTestException("Failed to verify zookeeper startup on port " + clientPort, e); } } }}
Loading