test: fix assuming toString order with multiple ports in org.apache.dubbo.rpc.protocol.dubbo.status.ThreadPoolStatusCheckerTest#16153
Open
Archonic944 wants to merge 2 commits intoapache:3.3from
Open
test: fix assuming toString order with multiple ports in org.apache.dubbo.rpc.protocol.dubbo.status.ThreadPoolStatusCheckerTest#16153Archonic944 wants to merge 2 commits intoapache:3.3from
Archonic944 wants to merge 2 commits intoapache:3.3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
The purpose of this change is to modify the test org.apache.dubbo.rpc.protocol.dubbo.status.ThreadPoolStatusCheckerTest so that it consistently succeeds.
Fixes #16152 .
Why does the test fail?
The test's implementation compares status message output (from a
ThreadPoolStatusChecker) against an expected string. The expected string contains an exact order, but theThreadPoolStatusCheckerin reality iterates over aMap.entrySet()to produce its static string. Therefore, iteration order is not guaranteed. When the map returns a different order than usual, which is valid under Java specifications, the test fails.How to reproduce the test failure
Run the test with NonDex to shuffle collection iteration order:
mvn edu.illinois:nondex-maven-plugin:2.2.1:nondex \ -pl dubbo-rpc/dubbo-rpc-dubbo \ -Dtest=org.apache.dubbo.rpc.protocol.dubbo.status.ThreadPoolStatusCheckerTest#test \ -DnondexRuns=10Expected results
The test expects
to be returned from
ThreadPoolStatusChecker#check#getMessage.Actual results
When the collection order is shuffled, the test receives
Description of Fix
Instead of comparing the status message to an exact string:
;. Ensure that there are only two items in the returned array.Checklist