Skip to content

fix: use thread-safe collections in SchemaDescriptorRegistry #16172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daguimu wants to merge 1 commit into
base: 3.3
Choose a base branch
from
+2 −8
Open

fix: use thread-safe collections in SchemaDescriptorRegistry #16172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ...ple/src/main/java/org/apache/dubbo/rpc/protocol/tri/service/SchemaDescriptorRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@

import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
Expand All @@ -35,7 +33,7 @@ public class SchemaDescriptorRegistry {

private static final Map<String, Map<Integer, FileDescriptor>> EXTENSIONS = new ConcurrentHashMap<>();

private static final Set<String> SERVICES = new HashSet<>();
private static final Set<String> SERVICES = ConcurrentHashMap.newKeySet();

public static void addSchemaDescriptor(String serviceName, FileDescriptor fd) {
SERVICES.add(serviceName);
Expand All @@ -58,11 +56,7 @@ private static void addType(Descriptor descriptor) {
private static void addExtension(FieldDescriptor extension, FileDescriptor fd) {
String name = extension.getContainingType().getFullName();
int number = extension.getNumber();
if (!EXTENSIONS.containsKey(name)) {
EXTENSIONS.put(name, new HashMap<>());
}
Map<Integer, FileDescriptor> fdMap = EXTENSIONS.get(name);
fdMap.put(number, fd);
EXTENSIONS.computeIfAbsent(name, k -> new ConcurrentHashMap<>()).put(number, fd);
}

public static FileDescriptor getFileDescriptorByExtensionAndNumber(String extension, int number) {
Expand Down
Loading