Remove tomcat embed dependencies declaration as spring-boot-starter-web has already included them#16173
Open
zrlw wants to merge 1 commit intoapache:3.3from
Open
Remove tomcat embed dependencies declaration as spring-boot-starter-web has already included them#16173zrlw wants to merge 1 commit intoapache:3.3from
zrlw wants to merge 1 commit intoapache:3.3from
Conversation
…eb has already included them
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16173 +/- ##
============================================
+ Coverage 60.80% 60.81% +0.01%
+ Complexity 11767 11751 -16
============================================
Files 1953 1953
Lines 89118 89118
Branches 13444 13444
============================================
+ Hits 54190 54200 +10
+ Misses 29367 29357 -10
Partials 5561 5561
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Remove tomcat embed dependencies declaration from
pom.xmlofdubbo-parentasspring-boot-starter-webhas already included them.dubbo-spring-boot-3-autoconfigureimportsspring-boot-dependenciespom which has definedtomcat.version.Otherwise

dependabot[bot]]always try to downgrade the tomcat version of profilespring-boot-3from 10.x to 9.x, e.g.,Checklist