Fix fastjson2 concurrent ref deserialization#16369
Open
goutamadwant wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16369 +/- ##
============================================
- Coverage 60.86% 60.47% -0.39%
+ Complexity 11768 10245 -1523
============================================
Files 1953 1953
Lines 89260 89264 +4
Branches 13471 13470 -1
============================================
- Hits 54329 53986 -343
- Misses 29350 29646 +296
- Partials 5581 5632 +51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Fixes #16368.
Fastjson2 JSONB deserialization can lose nested fields when multiple threads deserialize the same
$ref-heavy payload for the same target class at the same time. In the failing case, shared lists referenced by multiple child objects can becomenullafter concurrent deserialization.This change routes both
FastJson2ObjectInput#readObjectoverloads through a shared helper and synchronizes the fastjson2 parse per requested target class. The lock is backed byClassValue, so it does not retain application classes or classloaders, and unrelated DTO classes can still deserialize concurrently.The regression test serializes an object graph with shared nested lists, verifies a single read succeeds, then repeatedly deserializes the same payload from 200 threads while clearing fastjson2 reader caches between rounds. Without the fix, the test reports a non-zero count of null nested fields.
Tests:
FastJson2SerializationTest#testConcurrentReadObjectWithReferencesFastJson2SerializationTest,TypeMatchTestChecklist