Skip to content

FINERACT-2455: Add projected amortization schedule#5580

Draft
oleksii-novikov-onix wants to merge 2 commits intoapache:developfrom
openMF:FINERACT-2455/projected-amortization-schedule
Draft

FINERACT-2455: Add projected amortization schedule#5580
oleksii-novikov-onix wants to merge 2 commits intoapache:developfrom
openMF:FINERACT-2455/projected-amortization-schedule

Conversation

@oleksii-novikov-onix
Copy link
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/projected-amortization-schedule branch 8 times, most recently from c6878f0 to 5d8b091 Compare March 9, 2026 13:21
@adamsaghy
Copy link
Contributor

* What went wrong:
Execution failed for task ':fineract-e2e-tests-core:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/apache/fineract/test/stepdef/loan/WorkingCapitalAmortizationScheduleStepDef.java
          @@ -151,8 +151,7 @@
           ····················expected.get("actualPaymentAmount"));
           ············assertNullableDecimal(assertions,·p·+·"actualAmortizationAmount",·actual.getActualAmortizationAmount(),
           ····················expected.get("actualAmortizationAmount"));
          -············assertNullableDecimal(assertions,·p·+·"incomeModification",·actual.getIncomeModification(),
          -····················expected.get("incomeModification"));
          +············assertNullableDecimal(assertions,·p·+·"incomeModification",·actual.getIncomeModification(),·expected.get("incomeModification"));
           ············assertNullableDecimal(assertions,·p·+·"deferredBalance",·actual.getDeferredBalance(),·expected.get("deferredBalance"));
           ········}
           
          @@ -194,8 +193,7 @@
           ········assertions.assertThat(actual).as(field).isEqualTo(Long.parseLong(expectedStr));
           ····}
           
          -····private·static·void·assertDate(final·SoftAssertions·assertions,·final·String·field,·final·LocalDate·actual,
          -············final·String·expectedStr)·{
          +····private·static·void·assertDate(final·SoftAssertions·assertions,·final·String·field,·final·LocalDate·actual,·final·String·expectedStr)·{
           ········if·(expectedStr·==·null·||·expectedStr.isBlank())·{
           ············return;
           ········}
  Run './gradlew :fineract-e2e-tests-core:spotlessApply' to fix these violations.

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/projected-amortization-schedule branch 3 times, most recently from 0fea4f6 to 703aca4 Compare March 10, 2026 08:58
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/projected-amortization-schedule branch 4 times, most recently from 9309b61 to cdf09f3 Compare March 12, 2026 08:39
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use payment instead of installment, to avoid confusions as it does not define a period...

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/projected-amortization-schedule branch from cdf09f3 to b8d5961 Compare March 12, 2026 16:04
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/projected-amortization-schedule branch 2 times, most recently from 80b0fee to 2d50be4 Compare March 13, 2026 17:15
@adamsaghy
Copy link
Contributor

@oleksii-novikov-onix Please rebase.

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/projected-amortization-schedule branch 3 times, most recently from b7fc95b to 807def0 Compare March 17, 2026 10:59
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2455/projected-amortization-schedule branch from 807def0 to 89f5c18 Compare March 17, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants