FINERACT-2537: Add unit tests for StreamResponseUtil#5627
Open
devi-pathak2263 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2537: Add unit tests for StreamResponseUtil#5627devi-pathak2263 wants to merge 1 commit intoapache:developfrom
devi-pathak2263 wants to merge 1 commit intoapache:developfrom
Conversation
c8a58b9 to
327f5e5
Compare
Contributor
|
@devi-pathak2263 Can you please: Set the commit email address to match with your github account email address? |
327f5e5 to
34d4689
Compare
Author
I have updated the commit author email to match my GitHub account and amended the commit with a GPG signature. I also updated the test imports to follow project conventions. Please let me know if anything else needs adjustment. |
- Added unit tests covering response creation and streaming behavior - Improved async handling using Future.get() - Used ArgumentCaptor for stable verification - Ensured UTF-8 charset usage
34d4689 to
f2af213
Compare
Author
|
Hi team, could someone please approve the workflows for this PR so that CI checks can run? Thanks! |
Author
|
Hi team, all checks have passed. Please let me know if any further changes are required. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests for the 'StreamResponseUtil' utility class in 'fineract-core'.
The following scenarios are covered:
These tests improve code coverage and ensure reliable behavior of response streaming utilities.
JIRA:
https://issues.apache.org/jira/browse/FINERACT-2537
Testing
Executed locally:
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!