Skip to content

FINERACT-2544: update merge strategy guidance for FSIP-7#5644

Open
mansi75 wants to merge 2 commits intoapache:developfrom
mansi75:FINERACT-2544-remove-one-commit-per-user-check
Open

FINERACT-2544: update merge strategy guidance for FSIP-7#5644
mansi75 wants to merge 2 commits intoapache:developfrom
mansi75:FINERACT-2544-remove-one-commit-per-user-check

Conversation

@mansi75
Copy link

@mansi75 mansi75 commented Mar 18, 2026

Description

This PR removes the obsolete GitHub Action that enforced a one-commit-per-user rule on pull requests and updates the merge strategy guidance in CONTRIBUTING.md to align with the current Apache Fineract policy under FSIP-7.

Previously, the repository expected most PRs to consist of a single commit and included an automated check to fail PRs when the same contributor had multiple commits. However, the community has now adopted the traditional merge strategy in order to preserve commit history and retain verified signatures on individual commits. Because of that, the one-commit-per-user workflow is no longer valid and may incorrectly block legitimate contributions.

This change updates both repository behavior and contributor guidance so they are consistent with the new merge policy.

Checklist

  • Removed the obsolete one-commit-per-user GitHub Action workflow
  • Updated CONTRIBUTING.md to reflect the traditional merge strategy
  • Clarified that multiple commits per PR are allowed
  • Aligned repository checks and documentation with FSIP-7

@edk12564
Copy link
Contributor

edk12564 commented Mar 18, 2026

Hi @mansi75, please check the comment I made in https://issues.apache.org/jira/browse/FINERACT-2544?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel.

In short, I had an earlier PR that did the same thing. However, I think since you caught the README change as well, happy to go with your solution!

@mansi75 mansi75 force-pushed the FINERACT-2544-remove-one-commit-per-user-check branch from 36f6d2b to 420fe04 Compare March 18, 2026 19:10
@mansi75
Copy link
Author

mansi75 commented Mar 18, 2026

@edk12564 Got it! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants