FINERACT-2544: update merge strategy guidance for FSIP-7#5644
Open
mansi75 wants to merge 2 commits intoapache:developfrom
Open
FINERACT-2544: update merge strategy guidance for FSIP-7#5644mansi75 wants to merge 2 commits intoapache:developfrom
mansi75 wants to merge 2 commits intoapache:developfrom
Conversation
Contributor
|
Hi @mansi75, please check the comment I made in https://issues.apache.org/jira/browse/FINERACT-2544?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel. In short, I had an earlier PR that did the same thing. However, I think since you caught the README change as well, happy to go with your solution! |
36f6d2b to
420fe04
Compare
Author
|
@edk12564 Got it! Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the obsolete GitHub Action that enforced a one-commit-per-user rule on pull requests and updates the merge strategy guidance in
CONTRIBUTING.mdto align with the current Apache Fineract policy under FSIP-7.Previously, the repository expected most PRs to consist of a single commit and included an automated check to fail PRs when the same contributor had multiple commits. However, the community has now adopted the traditional merge strategy in order to preserve commit history and retain verified signatures on individual commits. Because of that, the one-commit-per-user workflow is no longer valid and may incorrectly block legitimate contributions.
This change updates both repository behavior and contributor guidance so they are consistent with the new merge policy.
Checklist
CONTRIBUTING.mdto reflect the traditional merge strategy