feat: implement ISO-GQL SAME predicate for element identity compariso… #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apache#368) Implement the ISO-GQL SAME predicate function to check if graph elements refer to the same entity by comparing their identities. This feature adds full ISO/IEC 39075:2024 Section 19.12 compliance for identity comparisons. Changes: - Parser Layer: * Add SqlSameCall AST node for SAME function calls * Add SqlSameOperator with BOOLEAN return type and VARIADIC operands * Register operator in BuildInSqlOperatorTable * Add syntax tests with 4 GQL test cases - Runtime Layer: * Implement GeaFlowBuiltinFunctions.same() for identity comparison - Vertex comparison: compares vertex IDs using Objects.equals() - Edge comparison: compares both source and target IDs - Null handling: returns null following SQL ternary logic - Type safety: returns false for mismatched types * Add BuildInExpression.SAME constant for expression translation * Register SAME in ExpressionTranslator.processOtherTrans() - Testing: * Add comprehensive SameTest with 13 unit tests (100% pass rate) * Test coverage: identical/different IDs, null handling, mixed types, string IDs, invalid types Implementation follows Approach 1 (Built-in Function Pattern) with minimal code changes (441 lines added across 9 files) for maximum simplicity and maintainability. Example usage: MATCH (a)->(b)->(c) WHERE SAME(a, c) RETURN a, b, c;
Contributor
Author
Contributor
Author
|
@Loognqiang PTAL |
1 similar comment
Contributor
Author
|
@Loognqiang PTAL |
yaozhongq
reviewed
Feb 2, 2026
...w-dsl-plan/src/main/java/org/apache/geaflow/dsl/schema/function/GeaFlowBuiltinFunctions.java
Show resolved
Hide resolved
…issue-368-iso-gql-same-predicate
- Fix SqlSameCall immutable operands list causing setOperand() failure - Add type-specific same() overloads for RowVertex and RowEdge - Add varargs same(Object...) for multi-element comparisons - Add comprehensive unit tests for all same() overloads
…issue-368-iso-gql-same-predicate
SeasonPilot
force-pushed
the
feature/issue-368-iso-gql-same-predicate
branch
from
26e8142 to
13d629f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n (#368)
Implement the ISO-GQL SAME predicate function to check if graph elements refer to the same entity by comparing their identities. This feature adds full ISO/IEC 39075:2024 Section 19.12 compliance for identity comparisons.
Changes:
Parser Layer:
Runtime Layer:
Testing:
Implementation follows Approach 1 (Built-in Function Pattern) with minimal code changes (441 lines added across 9 files) for maximum simplicity and maintainability.
Example usage:
MATCH (a)->(b)->(c) WHERE SAME(a, c) RETURN a, b, c;
What changes were proposed in this pull request?
How was this PR tested?